Skip to content

Commit cffa571

Browse files
KyleJuKyle Ju
andauthored
Launching feature href (#3747)
* Launching feature href * Playwright tests --------- Co-authored-by: Kyle Ju <[email protected]>
1 parent 913644d commit cffa571

11 files changed

+38
-4
lines changed

client-src/elements/chromedash-feature-detail.js

Lines changed: 38 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {LitElement, css, html, nothing} from 'lit';
2-
import {getFieldValueFromFeature, hasFieldValue, isDefinedValue, renderHTMLIf} from './utils';
2+
import {getFieldValueFromFeature, hasFieldValue, isDefinedValue} from './utils';
33
import {openAddStageDialog} from './chromedash-add-stage-dialog';
44
import {
55
openPrereqsDialog,
@@ -184,6 +184,17 @@ class ChromedashFeatureDetail extends LitElement {
184184
border: var(--spot-card-border);
185185
box-shadow: var(--spot-card-box-shadow);
186186
}
187+
188+
#new-stage {
189+
margin-left: 8px;
190+
margin-bottom: 4px;
191+
}
192+
193+
#footnote {
194+
margin-left: 8px;
195+
margin-bottom: 4px;
196+
margin-top: 4px;
197+
}
187198
`];
188199
}
189200

@@ -632,6 +643,19 @@ class ChromedashFeatureDetail extends LitElement {
632643
stageGates.length < 6);
633644
}
634645

646+
renderFootnote() {
647+
return html`
648+
<section id="footnote">
649+
Please see the
650+
<a href="https://www.chromium.org/blink/launching-features"
651+
target="_blank" rel="noopener">
652+
Launching features
653+
</a>
654+
page for process instructions.
655+
</section>
656+
`;
657+
}
658+
635659
renderStageMenu(feStage) {
636660
const items = [];
637661
if (this.offerAddXfnGates(feStage)) {
@@ -660,22 +684,32 @@ class ChromedashFeatureDetail extends LitElement {
660684
const text = this.feature.is_enterprise_feature ? 'Add Step': 'Add Stage';
661685

662686
return html`
663-
<sl-button size="small" @click="${
687+
<sl-button id="new-stage" size="small" @click="${
664688
() => openAddStageDialog(this.feature.id, this.feature.feature_type_int)}">
665689
${text}
666690
</sl-button>`;
667691
}
668692

693+
renderSectionHeader() {
694+
const text = this.feature.is_enterprise_feature ? 'Rollout steps' : 'Development stages';
695+
return html`
696+
<span>${text}
697+
<sl-icon-button name="info-circle" href="https://www.chromium.org/blink/launching-features"
698+
style="font-size: 0.8rem;" target="_blank" label="Launching feature guide">
699+
</sl-icon-button>
700+
</span>`;
701+
}
702+
669703
render() {
670704
return html`
671705
${this.renderMetadataSection()}
672706
<h2>
673-
${renderHTMLIf(!this.feature.is_enterprise_feature, html`<span>Development stages</span>`)}
674-
${renderHTMLIf(this.feature.is_enterprise_feature, html`<span>Rollout steps</span>`)}
707+
${this.renderSectionHeader()}
675708
${this.renderControls()}
676709
</h2>
677710
${this.feature.stages.map(feStage => this.renderProcessStage(feStage))}
678711
${this.renderAddStageButton()}
712+
${this.renderFootnote()}
679713
`;
680714
}
681715
}

0 commit comments

Comments
 (0)