Skip to content

Commit 78f50e5

Browse files
committed
Use <sl-relative-time> instead of Github's <relative-time>.
1 parent 3a10f32 commit 78f50e5

File tree

4 files changed

+13
-38
lines changed

4 files changed

+13
-38
lines changed

client-src/elements/chromedash-link.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// @ts-check
22

3-
import '@github/relative-time-element';
43
import {css, html, LitElement} from 'lit';
54
import {ifDefined} from 'lit/directives/if-defined.js';
65
import {SHARED_STYLES} from '../css/shared-css';
@@ -128,7 +127,7 @@ function enhanceGithubIssueLink(featureLink, text) {
128127
if (stateVariant === undefined) {
129128
if (state === 'open') {
130129
const age = Date.now() - createdAt.getTime();
131-
stateDescription = html`Opened <relative-time .date=${createdAt} format="relative" precision="day" threshold="P100Y">on ${_dateTimeFormat.format(createdAt)}</relative-time>`;
130+
stateDescription = html`Opened <sl-relative-time date=${createdAt.toISOString()}>on ${_dateTimeFormat.format(createdAt)}</sl-relative-time>`;
132131
const week = 7 * 24 * 60 * 60 * 1000;
133132
stateVariant = 'success';
134133
if (externalReviewer) {
@@ -403,6 +402,10 @@ export class ChromedashLink extends LitElement {
403402
background-color: rgb(209,211,213);
404403
}
405404
405+
sl-relative-time {
406+
margin: 0;
407+
}
408+
406409
.icon {
407410
display: block;
408411
width: 12px;

client-src/elements/chromedash-link_test.js

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,9 @@ describe('Github issue links', () => {
100100
src="https://docs.github.com/assets/cb-600/images/site/favicon.png">
101101
<sl-badge size="small" variant="success">
102102
Opened
103-
<relative-time
104-
datetime="${yesterday.toISOString()}"
105-
format="relative"
106-
precision="day"
107-
threshold="P100Y">
103+
<sl-relative-time date="${yesterday.toISOString()}">
108104
on ${_dateTimeFormat.format(yesterday)}
109-
</relative-time>
105+
</sl-relative-time>
110106
</sl-badge>
111107
#3007 Issue Title
112108
</sl-tag>
@@ -348,13 +344,9 @@ describe('Github issue links', () => {
348344
src="https://avatars.githubusercontent.com/u/131524?s=48&amp;v=4">
349345
<sl-badge size="small" variant="danger">
350346
Opened
351-
<relative-time
352-
datetime="${lastWeek.toISOString()}"
353-
format="relative"
354-
precision="day"
355-
threshold="P100Y">
347+
<sl-relative-time date="${lastWeek.toISOString()}">
356348
on ${_dateTimeFormat.format(lastWeek)}
357-
</relative-time>
349+
</sl-relative-time>
358350
</sl-badge>
359351
#975 The textInput event
360352
</sl-tag>
@@ -388,13 +380,9 @@ describe('Github issue links', () => {
388380
src="https://avatars.githubusercontent.com/u/131524?s=48&amp;v=4">
389381
<sl-badge size="small" variant="warning">
390382
Opened
391-
<relative-time
392-
datetime="${threeWeeks.toISOString()}"
393-
format="relative"
394-
precision="day"
395-
threshold="P100Y">
383+
<sl-relative-time date="${threeWeeks.toISOString()}">
396384
on ${_dateTimeFormat.format(threeWeeks)}
397-
</relative-time>
385+
</sl-relative-time>
398386
</sl-badge>
399387
#975 The textInput event
400388
</sl-tag>
@@ -428,13 +416,9 @@ describe('Github issue links', () => {
428416
src="https://avatars.githubusercontent.com/u/131524?s=48&amp;v=4">
429417
<sl-badge size="small" variant="neutral">
430418
Opened
431-
<relative-time
432-
datetime="${twoMonths.toISOString()}"
433-
format="relative"
434-
precision="day"
435-
threshold="P100Y">
419+
<sl-relative-time date="${twoMonths.toISOString()}">
436420
on ${_dateTimeFormat.format(twoMonths)}
437-
</relative-time>
421+
</sl-relative-time>
438422
</sl-badge>
439423
#975 The textInput event
440424
</sl-tag>

package-lock.json

Lines changed: 0 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@
102102
"typescript": "^5.4.2"
103103
},
104104
"dependencies": {
105-
"@github/relative-time-element": "^4.3.1",
106105
"@lit/task": "^1.0.0",
107106
"@polymer/iron-collapse": "^3.0.1",
108107
"@polymer/iron-icon": "^3.0.1",

0 commit comments

Comments
 (0)