Skip to content

Commit 51224de

Browse files
authored
Fix ietf yang search path for cvl schema builds (sonic-net#32)
1) Fixed pyang search paths in cvl schema makefiles to include top models/yang/common directory. Without this pyang may not locate ietf yangs during cvl schema builds, especially while building outside sonic slave docker. 2) Updated go.mode and go.sum files to include new dependencies added during recent cvl enhancemnts
1 parent 3c6cdb3 commit 51224de

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

cvl/schema/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ out_platform=$(patsubst %.yang, $(out_dir)/%.yin, $(shell find $(sonic_yang_plat
3434
out_platform_dep=$(shell find $(sonic_yang_platform) -name '*.yang')
3535
out_tree=$(patsubst %.yang, $(out_dir)/%.tree, $(src_files))
3636

37-
search_path=$(sonic_yang):$(sonic_yang_common):$(sonic_yang_common)/ietf
37+
search_path=$(std_yang_common):$(sonic_yang):$(sonic_yang_common)
3838

3939

4040
all: precheck schema

cvl/testdata/schema/Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,14 @@
1919

2020
TOPDIR?=$(abspath ../../../)
2121

22+
yang_dir=../../../models/yang
2223
sonic_yang=../../../models/yang/sonic
2324
pyang_plugin_dir=../../../tools/pyang/pyang_plugins
2425
src_files=$(wildcard *.yang)
2526
out_dir=$(TOPDIR)/build/tests/cvl/testdata/schema/
2627
out=$(patsubst %.yang, $(out_dir)/%.yin, $(src_files))
2728
out_ext=$(patsubst %.yang, $(out_dir)/%.tree, $(src_files))
29+
search_path=$(yang_dir)/common:$(sonic_yang):$(sonic_yang)/common
2830

2931
all:precheck schema
3032

@@ -39,14 +41,14 @@ $(out_dir)/%.yin:%.yang
3941
@echo "Generating `basename $@` ..."
4042
@devFile="`echo $< | cut -d . -f1`-deviation.yang"; \
4143
if [ -f $$devFile ] ; then devOpt="--deviation-module $$devFile"; fi; \
42-
pyang -p $(sonic_yang)/common:$(sonic_yang)/common/ietf \
44+
pyang -p $(search_path) \
4345
--plugindir $(pyang_plugin_dir) -f yin-cvl $$devOpt $< -o $@
4446

4547
$(out_dir)/%.tree:%.yang
4648
@echo "Generating `basename $@` ..."
4749
@devFile="`echo $< | cut -d . -f1`-deviation.yang"; \
4850
if [ -f $$devFile ] ; then devOpt="--deviation-module $$devFile"; fi; \
49-
pyang -p $(sonic_yang)/common:$(sonic_yang)/common/ietf \
51+
pyang -p $(search_path) \
5052
-f tree $$devOpt $< -o $@
5153

5254
clean:

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ require (
44
github.com/Workiva/go-datastructures v1.0.50
55
github.com/antchfx/jsonquery v1.1.0
66
github.com/antchfx/xmlquery v1.2.1
7-
github.com/antchfx/xpath v1.1.2 // indirect
7+
github.com/antchfx/xpath v1.1.2
88
github.com/go-redis/redis v6.15.6+incompatible
9-
github.com/go-redis/redis/v7 v7.0.0-beta.3.0.20190824101152-d19aba07b476 // indirect
9+
github.com/go-redis/redis/v7 v7.0.0-beta.3.0.20190824101152-d19aba07b476
1010
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
1111
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect
1212
github.com/openconfig/gnmi v0.0.0-20200617225440-d2b4e6a45802

go.sum

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7
1919
github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
2020
github.com/go-redis/redis v6.15.6+incompatible h1:H9evprGPLI8+ci7fxQx6WNZHJSb7be8FqJQRhdQZ5Sg=
2121
github.com/go-redis/redis v6.15.6+incompatible/go.mod h1:NAIEuMOZ/fxfXJIrKDQDz8wamY7mA7PouImQ2Jvg6kA=
22+
github.com/go-redis/redis/v7 v7.0.0-beta.3.0.20190824101152-d19aba07b476 h1:WNSiFp8Ww4ZP7XUzW56zDYv5roKQ4VfsdHCLoh8oDj4=
2223
github.com/go-redis/redis/v7 v7.0.0-beta.3.0.20190824101152-d19aba07b476/go.mod h1:xhhSbUMTsleRPur+Vgx9sUHtyN33bdjxY+9/0n9Ig8s=
2324
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b h1:VKtxabqXZkF25pY9ekfRL6a582T4P37/31XEstQ5p58=
2425
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=

0 commit comments

Comments
 (0)