Merge branch 'main' into PBE-5855-feat/react-native-video-design-v2

Author: kristian-mkd

.github/workflows/version-and-release.yml

@@ -4,11 +4,11 @@ env:
   STREAM_SECRET: ${{ secrets.CLIENT_TEST_SECRET }}
 
 on:
-  push:
-    branches:
-      - main
-    paths:
-      - 'packages/**'
+  # push:
+  #  branches:
+  #    - main
+  #  paths:
+  #    - 'packages/**'
 
   workflow_dispatch:
 

packages/client/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver).
 
+## [1.8.3](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.8.2...@stream-io/video-client-1.8.3) (2024-10-10)
+
+
+### Bug Fixes
+
+* do not release track if track was not removed from stream ([#1517](https://github.com/GetStream/stream-video-js/issues/1517)) ([5bfc528](https://github.com/GetStream/stream-video-js/commit/5bfc52850c36ffe0de37e47066538a8a14dc9e01))
+
 ## [1.8.2](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.8.1...@stream-io/video-client-1.8.2) (2024-10-10)
 
 

packages/client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stream-io/video-client",
-  "version": "1.8.2",
+  "version": "1.8.3",
   "packageManager": "[email protected]",
   "main": "dist/index.cjs.js",
   "module": "dist/index.es.js",

packages/client/src/devices/InputMediaDeviceManager.ts

@@ -279,14 +279,7 @@ export abstract class InputMediaDeviceManager<
 
   private stopTracks() {
     this.getTracks().forEach((track) => {
-      if (track.readyState === 'live') {
-        track.stop();
-        // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-        if (typeof track.release === 'function') {
-          // @ts-expect-error
-          track.release();
-        }
-      }
+      if (track.readyState === 'live') track.stop();
     });
   }
 

packages/client/src/devices/devices.ts

@@ -276,12 +276,6 @@ export const disposeOfMediaStream = (stream: MediaStream) => {
   if (!stream.active) return;
   stream.getTracks().forEach((track) => {
     track.stop();
-    stream.removeTrack(track);
-    // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-    if (typeof track.release === 'function') {
-      // @ts-expect-error
-      track.release();
-    }
   });
   // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the stream
   if (typeof stream.release === 'function') {

packages/client/src/helpers/RNSpeechDetector.ts

@@ -106,14 +106,7 @@ export class RNSpeechDetector {
     if (!this.audioStream) {
       return;
     }
-    this.audioStream.getTracks().forEach((track) => {
-      track.stop();
-      // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-      if (typeof track.release === 'function') {
-        // @ts-expect-error
-        track.release();
-      }
-    });
+    this.audioStream.getTracks().forEach((track) => track.stop());
     if (
       // @ts-expect-error release() is present in react-native-webrtc
       typeof this.audioStream.release === 'function'

packages/client/src/rtc/Publisher.ts

@@ -316,11 +316,6 @@ export class Publisher {
       if (previousTrack && previousTrack !== track) {
         previousTrack.stop();
         previousTrack.removeEventListener('ended', handleTrackEnded);
-        // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-        if (typeof previousTrack.release === 'function') {
-          // @ts-expect-error
-          track.release();
-        }
         track.addEventListener('ended', handleTrackEnded);
       }
       if (!track.enabled) {
@@ -342,18 +337,16 @@ export class Publisher {
     const transceiver = this.pc
       .getTransceivers()
       .find((t) => t === this.transceiverRegistry[trackType] && t.sender.track);
-    const track = transceiver?.sender.track;
-    if (track && (stopTrack ? track.readyState === 'live' : track.enabled)) {
-      if (stopTrack) {
-        track.stop();
-        // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-        if (typeof track.release === 'function') {
-          // @ts-expect-error
-          track.release();
-        }
-      } else {
-        track.enabled = false;
-      }
+    if (
+      transceiver &&
+      transceiver.sender.track &&
+      (stopTrack
+        ? transceiver.sender.track.readyState === 'live'
+        : transceiver.sender.track.enabled)
+    ) {
+      stopTrack
+        ? transceiver.sender.track.stop()
+        : (transceiver.sender.track.enabled = false);
       // We don't need to notify SFU if unpublishing in response to remote soft mute
       if (this.state.localParticipant?.publishedTracks.includes(trackType)) {
         await this.notifyTrackMuteStateChanged(undefined, trackType, true);
@@ -406,13 +399,7 @@ export class Publisher {
   private stopPublishing = () => {
     this.logger('debug', 'Stopping publishing all tracks');
     this.pc.getSenders().forEach((s) => {
-      const track = s.track;
-      track?.stop();
-      // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-      if (typeof track?.release === 'function') {
-        // @ts-expect-error
-        track.release();
-      }
+      s.track?.stop();
       if (this.pc.signalingState !== 'closed') {
         this.pc.removeTrack(s);
       }

packages/react-bindings/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver).
 
+## [1.1.3](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-react-bindings-1.1.2...@stream-io/video-react-bindings-1.1.3) (2024-10-10)
+
+### Dependency Updates
+
+* `@stream-io/video-client` updated to version `1.8.3`
 ## [1.1.2](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-react-bindings-1.1.1...@stream-io/video-react-bindings-1.1.2) (2024-10-10)
 
 ### Dependency Updates

packages/react-bindings/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stream-io/video-react-bindings",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "packageManager": "[email protected]",
   "main": "./dist/index.cjs.js",
   "module": "./dist/index.es.js",

packages/react-native-sdk/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver).
 
+## [1.1.5](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-react-native-sdk-1.1.4...@stream-io/video-react-native-sdk-1.1.5) (2024-10-16)
+
+
+### Bug Fixes
+
+* **react-native:** set objectFit based on actual video track dimensions ([#1520](https://github.com/GetStream/stream-video-js/issues/1520)) ([44ef7d2](https://github.com/GetStream/stream-video-js/commit/44ef7d2e69a910be45b2d3a7643c3f58e0f29803))
+
+## [1.1.4](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-react-native-sdk-1.1.3...@stream-io/video-react-native-sdk-1.1.4) (2024-10-10)
+
+### Dependency Updates
+
+* `@stream-io/video-client` updated to version `1.8.3`
+* `@stream-io/video-react-bindings` updated to version `1.1.3`
 ## [1.1.3](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-react-native-sdk-1.1.2...@stream-io/video-react-native-sdk-1.1.3) (2024-10-10)
 
 ### Dependency Updates