Skip to content

Commit e58c20a

Browse files
Slind14dluxemburg
authored andcommitted
added missing dfpAdServerVideo.js dfp vast tag generation uri compone… (prebid#2440)
* added missing dfpAdServerVideo.js dfp vast tag generation uri component encoding * fixed buildDfpVideoUrl not returning empty targeting * reverted last commits change because it broke display targeting
1 parent e277bc7 commit e58c20a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/dfpAdServerVideo.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export default function buildDfpVideoUrl(options) {
8080
const derivedParams = {
8181
correlator: Date.now(),
8282
sz: parseSizesInput(adUnit.sizes).join('|'),
83-
url: location.href,
83+
url: encodeURIComponent(location.href),
8484
};
8585
const encodedCustomParams = getCustParams(bid, options);
8686

@@ -152,7 +152,7 @@ function getCustParams(bid, options) {
152152
adserverTargeting,
153153
{ hb_uuid: bid && bid.videoCacheKey },
154154
// hb_uuid will be deprecated and replaced by hb_cache_id
155-
{hb_cache_id: bid && bid.videoCacheKey},
155+
{ hb_cache_id: bid && bid.videoCacheKey },
156156
optCustParams,
157157
);
158158
return encodeURIComponent(formatQS(customParams));

src/targeting.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const isBidExpired = (bid) => (bid.responseTimestamp + bid.ttl * 1000 + T
2222
const isUnusedBid = (bid) => bid && ((bid.status && !includes([BID_TARGETING_SET, RENDERED], bid.status)) || !bid.status);
2323

2424
// If two bids are found for same adUnitCode, we will use the latest one to take part in auction
25-
// This can happen in case of concurrent autions
25+
// This can happen in case of concurrent auctions
2626
export const getOldestBid = function(bid, i, arr) {
2727
let oldestBid = true;
2828
arr.forEach((val, j) => {

0 commit comments

Comments
 (0)