Skip to content

Add info text that explains the filters #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengelniederhammer opened this issue Feb 4, 2025 · 1 comment
Open

Add info text that explains the filters #524

fengelniederhammer opened this issue Feb 4, 2025 · 1 comment

Comments

@fengelniederhammer
Copy link
Contributor

No description provided.

@JonasKellerer
Copy link
Contributor

Possible implementation idea:

In SequencingEffortsPageStateSelector, CompareVariantsToBaselineStateSelector, CompareVariantsPageStateSelector and SingleVariantPageStateSelector above the filters.

<div className='mb-2 flex justify-end gap-4 text-sm'>
                <ButtonWithIcon icon={'mdi--tooltip-help-outline'}>
                    <div>Help</div>
                </ButtonWithIcon>
                <ButtonWithIcon icon={'mdi--wrench'}>
                    <div>Add filter fields</div>
                </ButtonWithIcon>
                <ButtonWithIcon icon={'mdi--circle-arrows'}>
                    <div>Reset</div>
                </ButtonWithIcon>
            </div>
            <hr className='mb-2 border-gray-200' />

with

import type { JSX, PropsWithChildren } from 'react';

export function ButtonWithIcon({
    children,
    icon,
    onClick,
}: PropsWithChildren<{
    icon: string;
    onClick?: JSX.IntrinsicElements['button']['onClick'];
}>) {
    return (
        <button className='flex items-center gap-1 hover:underline' onClick={onClick}>
            <div className={`iconify ${icon}`}></div>
            {children}
        </button>
    );
}

and in CompareSideBySidePageStateSelector:

<hr className='my-2 border-gray-200' />
            <div className='mb-2 flex justify-end gap-4 text-sm'>
                <ButtonWithIcon icon={'mdi--tooltip-help-outline'}>
                    <div>Help</div>
                </ButtonWithIcon>
                <ButtonWithIcon icon={'mdi--wrench'}>
                    <div>Add filter fields</div>
                </ButtonWithIcon>
                <ButtonWithIcon icon={'mdi--circle-arrows'}>
                    <div>Reset</div>
                </ButtonWithIcon>
            </div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants