Skip to content

feat(lapis): add fields property to mutation endpoints #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fengelniederhammer
Copy link
Contributor

If fields is not empty, then the response will only contain the fields that were specified there.

resolves #1092

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lapis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 2:12pm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 21 changed files in this pull request and generated no comments.

Files not reviewed (18)
  • lapis/src/main/kotlin/org/genspectrum/lapis/controller/ControllerDescriptions.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/controller/LapisController.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/model/SiloQueryModel.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/openApi/OpenApiDocs.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/openApi/Schemas.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/request/Field.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/request/MutationProportionsRequest.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/request/SequenceFiltersRequestWithFields.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/response/LapisResponse.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/response/ResponseCollections.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/response/SiloResponse.kt: Language not supported
  • lapis/src/main/kotlin/org/genspectrum/lapis/silo/SiloQuery.kt: Language not supported
  • lapis/src/test/kotlin/org/genspectrum/lapis/controller/Helpers.kt: Language not supported
  • lapis/src/test/kotlin/org/genspectrum/lapis/controller/LapisControllerDataFormatTest.kt: Language not supported
  • lapis/src/test/kotlin/org/genspectrum/lapis/controller/LapisControllerTest.kt: Language not supported
  • lapis/src/test/kotlin/org/genspectrum/lapis/controller/MockData.kt: Language not supported
  • lapis/src/test/kotlin/org/genspectrum/lapis/model/SiloQueryModelTest.kt: Language not supported
  • lapis/src/test/kotlin/org/genspectrum/lapis/request/MutationProportionsRequestTest.kt: Language not supported
Comments suppressed due to low confidence (2)

lapis-e2e/test/nucleotideMutations.spec.ts:32

  • [nitpick] Consider clarifying the test description to emphasize that only the specified field is returned. For example, use something like 'should return only the specified mutation field when using fields filter'.
it('should return only mutation when asking for only mutation', async () => {

lapis-e2e/test/aminoAcidMutations.spec.ts:32

  • [nitpick] Consider clarifying the test description to better indicate that only the specified mutation field is returned when the fields filter is applied. A more descriptive message can improve clarity.
it('should return only mutation when asking for only mutation', async () => {

Copy link
Contributor

github-actions bot commented Apr 8, 2025

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.4.3 (2025-04-09)

Features

  • lapis: add fields property to mutation endpoints (1b59de8), closes #1092

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Only some minor refactoring and one unit test case left.

If `fields` is not empty, then the response will only contain the fields that were specified there.

resolves #1092
@fengelniederhammer fengelniederhammer force-pushed the 1092-think-about-fields-on-mutations-endpoints branch from 8dc0324 to 1b59de8 Compare April 9, 2025 14:12
@fengelniederhammer fengelniederhammer merged commit 4d8df3a into main Apr 9, 2025
9 checks passed
@fengelniederhammer fengelniederhammer deleted the 1092-think-about-fields-on-mutations-endpoints branch April 9, 2025 14:34
fengelniederhammer added a commit that referenced this pull request Apr 15, 2025
I think this was introduced by first merging #1149 (which added the tests)
and then merging a non-rebased #1135 (which changed that open api generator version).
fengelniederhammer added a commit that referenced this pull request Apr 15, 2025
I think this was introduced by first merging #1149 (which added the tests)
and then merging a non-rebased #1135 (which changed the open api generator version).
fengelniederhammer added a commit that referenced this pull request Apr 15, 2025
I think this was introduced by first merging #1149 (which added the tests)
and then merging a non-rebased #1135 (which changed the open api generator version).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Think about: fields on mutations endpoints?
2 participants