-
Notifications
You must be signed in to change notification settings - Fork 7
feat(lapis): add fields
property to mutation endpoints
#1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lapis): add fields
property to mutation endpoints
#1149
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (18)
- lapis/src/main/kotlin/org/genspectrum/lapis/controller/ControllerDescriptions.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/controller/LapisController.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/model/SiloQueryModel.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/openApi/OpenApiDocs.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/openApi/Schemas.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/request/Field.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/request/MutationProportionsRequest.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/request/SequenceFiltersRequestWithFields.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/response/LapisResponse.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/response/ResponseCollections.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/response/SiloResponse.kt: Language not supported
- lapis/src/main/kotlin/org/genspectrum/lapis/silo/SiloQuery.kt: Language not supported
- lapis/src/test/kotlin/org/genspectrum/lapis/controller/Helpers.kt: Language not supported
- lapis/src/test/kotlin/org/genspectrum/lapis/controller/LapisControllerDataFormatTest.kt: Language not supported
- lapis/src/test/kotlin/org/genspectrum/lapis/controller/LapisControllerTest.kt: Language not supported
- lapis/src/test/kotlin/org/genspectrum/lapis/controller/MockData.kt: Language not supported
- lapis/src/test/kotlin/org/genspectrum/lapis/model/SiloQueryModelTest.kt: Language not supported
- lapis/src/test/kotlin/org/genspectrum/lapis/request/MutationProportionsRequestTest.kt: Language not supported
Comments suppressed due to low confidence (2)
lapis-e2e/test/nucleotideMutations.spec.ts:32
- [nitpick] Consider clarifying the test description to emphasize that only the specified field is returned. For example, use something like 'should return only the specified mutation field when using fields filter'.
it('should return only mutation when asking for only mutation', async () => {
lapis-e2e/test/aminoAcidMutations.spec.ts:32
- [nitpick] Consider clarifying the test description to better indicate that only the specified mutation field is returned when the fields filter is applied. A more descriptive message can improve clarity.
it('should return only mutation when asking for only mutation', async () => {
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.4.3 (2025-04-09)Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Only some minor refactoring and one unit test case left.
lapis/src/main/kotlin/org/genspectrum/lapis/model/SiloQueryModel.kt
Outdated
Show resolved
Hide resolved
0a76a50
to
8dc0324
Compare
If `fields` is not empty, then the response will only contain the fields that were specified there. resolves #1092
8dc0324
to
1b59de8
Compare
If
fields
is not empty, then the response will only contain the fields that were specified there.resolves #1092
PR Checklist