Skip to content

feat(lapis): pass through coverage from SILO in mutation endpoints #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fengelniederhammer
Copy link
Contributor

resolves #1091

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lapis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:15pm

Copy link
Contributor

github-actions bot commented Feb 27, 2025

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.3.15 (2025-02-27)

Features

  • lapis: pass through coverage from SILO in mutation endpoints (49696b9), closes #1091

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me.
Maybe not this PR, but we could add a sentence to /docs/concepts/ambiguous-symbols that you can get the coverage in a mutation query. But maybe this is also not necessary.

@fengelniederhammer
Copy link
Contributor Author

Nice. Looks good to me. Maybe not this PR, but we could add a sentence to /docs/concepts/ambiguous-symbols that you can get the coverage in a mutation query. But maybe this is also not necessary.

It should actually also already be clear from the Swagger description (if the users finds it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hand through mutation coverage from SILO
2 participants