Refactor/clean up code (#451)

Author: TheGreatRefrigerator

src/fragments/box/box.js

@@ -162,7 +162,6 @@ export default {
      * if it is not the last one (over the other)
      * Method is intended to be called when the global
      * event `boxMaximizedStackChanged` if emitted
-     * @param {*} value
      */
     syncBoxesMaximized () {
       // We can have a list of boxes considered as maximized, but only the

src/fragments/charts/altitude/altitude.js

@@ -4,14 +4,14 @@ import MapViewData from '@/models/map-view-data'
 import {EventBus} from '@/common/event-bus'
 import theme from '@/config/theme'
 import {
-  Chart as ChartJS,
   CategoryScale,
+  Chart as ChartJS,
+  Filler,
+  Legend,
   LinearScale,
-  PointElement,
   LineElement,
-  Tooltip,
-  Legend,
-  Filler
+  PointElement,
+  Tooltip
 } from 'chart.js'
 
 ChartJS.register(

src/fragments/footer/footer.js

@@ -1,5 +1,6 @@
 import appConfig from '@/config/app-config'
 import theme from '@/config/theme'
+
 export default {
   data () {
     return {

src/fragments/forms/fields-container/components/form-fields/form-fields.js

@@ -127,7 +127,6 @@ export default {
     /**
      * Update filed modal when the combo component triggers an update
      * @param {*} index
-     * @param {*} newVal
      */
     sliderComboUpdated (index) {
       let parameter = this.parameters[index]
@@ -156,6 +155,7 @@ export default {
     /**
      * Set item option structure and translation
      * @param {Array} items
+     * @param parameter
      * @return {Array} items
      */
     adjustItems (items, parameter) {
@@ -187,6 +187,7 @@ export default {
     /**
      * Get item translation by item value
      * @param {String} itemValue
+     * @param parameter
      * @returns {String}
      */
     getItemTranslation (itemValue, parameter) {

src/fragments/forms/fields-container/components/slider-combo/slider-combo.js

@@ -1,4 +1,3 @@
-
 import customSlider from './custom-slider'
 
 export default {

src/fragments/forms/map-form/components/download/download.js

@@ -1,5 +1,5 @@
 import OrsParamsParser from '@/support/map-data-services/ors-params-parser'
-import { Directions } from '@/support/ors-api-runner'
+import {Directions} from '@/support/ors-api-runner'
 import MapViewData from '@/models/map-view-data'
 import constants from '@/resources/constants'
 import toKml from '@maphubs/tokml'

src/fragments/forms/map-form/components/isochrones/isochrones.css

@@ -14,9 +14,7 @@ ul.place-inputs li {
 }
 
 ul.place-inputs {
-  padding: 0;
-  padding-top: 10px;
-  padding-bottom: 10px;
+  padding: 10px 0;
 }
 
 .extra-btn {

src/fragments/forms/map-form/components/isochrones/isochrones.js

@@ -3,7 +3,7 @@ import MapViewDataBuilder from '@/support/map-data-services/map-view-data-builde
 import FieldsContainer from '@/fragments/forms/fields-container/FieldsContainer'
 import OrsFilterUtil from '@/support/map-data-services/ors-filter-util'
 import PlaceInput from '@/fragments/forms/place-input/PlaceInput.vue'
-import { Isochrones } from '@/support/ors-api-runner'
+import {Isochrones} from '@/support/ors-api-runner'
 import AppMode from '@/support/app-modes/app-mode'
 import MapViewData from '@/models/map-view-data'
 import constants from '@/resources/constants'
@@ -261,7 +261,6 @@ export default {
     /**
      * Handle the route places error response displaying the correct message
      * @param {*} result
-     * @param {*} args
      */
     handleCalculateIsochronesError (result) {
       this.$root.appHooks.run('beforeHandleIsochronesError', result)

src/fragments/forms/map-form/components/place-and-directions/components/route-details/components/extras/route-extras.js

@@ -89,7 +89,7 @@ export default {
      * Build and return
      * the segment style object
      * @param {String} extraKey
-     * @param {Number} amount
+     * @param summary amount, value
      * @param {Integer} index
      * @returns {Object}
      */

src/fragments/forms/map-form/components/place-and-directions/places-and-directions.css

@@ -11,9 +11,7 @@
 }
 
 ul.place-inputs {
-  padding: 0;
-  padding-top: 10px;
-  padding-bottom: 10px;
+  padding: 10px 0;
 }
 
 ul.place-inputs li {

src/fragments/forms/map-form/components/place-and-directions/places-and-directions.js

@@ -4,7 +4,7 @@ import OrsParamsParser from '@/support/map-data-services/ors-params-parser'
 import OrsFilterUtil from '@/support/map-data-services/ors-filter-util'
 import PlaceInput from '@/fragments/forms/place-input/PlaceInput.vue'
 import MapFormBtn from '@/fragments/forms/map-form-btn/MapFormBtn'
-import { Directions } from '@/support/ors-api-runner'
+import {Directions} from '@/support/ors-api-runner'
 import AppMode from '@/support/app-modes/app-mode'
 import MapViewData from '@/models/map-view-data'
 import constants from '@/resources/constants'
@@ -668,7 +668,6 @@ export default {
     /**
      * Handle the route places error response displaying the correct message
      * @param {*} result
-     * @param {*} args
      */
     handleCalculateDirectionsError (result) {
       this.$root.appHooks.run('beforeHandleDirectionsError', result)
@@ -905,7 +904,6 @@ export default {
 
     /**
      * Toggle the round trip state view mode
-     * @param {Boolean} roundTripActive
      */
     toggleRoundTrip () {
       // If it is in roundTrip mode, we must be reset to single place mode

src/fragments/forms/map-form/map-form.css

@@ -11,8 +11,7 @@
 }
 
 ul.place-inputs {
-  padding: 0;
-  padding-top: 10px;
+  padding: 10px 0 0;
 }
 
 ul.place-inputs li {

src/fragments/forms/place-input/place-input.js

@@ -1,4 +1,4 @@
-import { PlacesSearch, ReverseGeocode } from '@/support/ors-api-runner'
+import {PlacesSearch, ReverseGeocode} from '@/support/ors-api-runner'
 import AppMode from '@/support/app-modes/app-mode'
 import constants from '@/resources/constants'
 import appConfig from '@/config/app-config'
@@ -214,7 +214,6 @@ export default {
     },
     /**
      * Get the place input label based on the current view mode
-     * @param {*} index
      */
     placeInputLabel () {
       let label = null
@@ -332,7 +331,7 @@ export default {
     /**
      * highlight typed place name
      * @param {String} placeName
-     * @returns {Html}
+     * @returns {string}
      */
     highlightedName (placeName) {
       let searchMask = this.localModel.placeName
@@ -738,7 +737,6 @@ export default {
 
     /**
      * Reset a place input at a given index
-     * @param {*} index
      */
     placeCleared () {
       if (!this.model.isEmpty()) {

src/fragments/forms/profile-selector/components/profile-selector-option/profile-selector-option.js

@@ -1,4 +1,3 @@
-
 import utils from '@/support/utils'
 
 export default {

src/fragments/forms/profile-selector/profile-selector.js

@@ -69,17 +69,6 @@ export default {
       return filterRef.value
     },
 
-    /**
-     * Get the primary profiles
-     * @returns {Array}
-     */
-    getPrimaryProfiles () {
-      const primaryProfiles = this.lodash.filter(this.profilesMapping, (p) => {
-        return p.primary === true
-      })
-      return primaryProfiles
-    },
-
     notifyProfileChanged () {
       EventBus.$emit('filtersChangedExternally')
     },

src/fragments/forms/route-importer/route-importer.js

@@ -58,6 +58,7 @@ export default {
      * Catch file contents and type, parse and call load
      * @param {*} fileContent
      * @param {*} type
+     * @param timestamp
      */
     catchAndParseFile (fileContent, type, timestamp) {
       let fileType = null

src/fragments/map-view/components/map-left-click/map-left-click.js

@@ -6,7 +6,7 @@
  * @listens mapRightClicked
  * @listens mapLeftClicked (to close the right click pop up)
  */
-import { ReverseGeocode } from '@/support/ors-api-runner'
+import {ReverseGeocode} from '@/support/ors-api-runner'
 import GeoUtils from '@/support/geo-utils'
 import Place from '@/models/place'
 import {EventBus} from '@/common/event-bus'
@@ -99,9 +99,8 @@ export default {
     },
     /**
      * Resolve the coordinates of a point to a qualified location
-     * @param lar
+     * @param lat
      * @param lng
-     * @param options
      * @returns {Promise}
      * @emits showLoading (via EventBus)
      */

src/fragments/map-view/components/map-view-markers/map-view-markers.js

@@ -1,6 +1,6 @@
 import Vue2LeafletMarkerCluster from 'vue2-leaflet-markercluster'
 import constants from '@/resources/constants'
-import {LMarker, LPopup } from 'vue2-leaflet'
+import {LMarker, LPopup} from 'vue2-leaflet'
 import appConfig from '@/config/app-config'
 
 import 'leaflet.markercluster/dist/MarkerCluster.css'

src/fragments/map-view/components/ors-l-polyline/ors-extended-polyline.js

@@ -367,10 +367,7 @@ class OrsExtendedPolyline {
       return true
     }
 
-    if ((this.options.vertices.middle === false || this.options.vertices.insert === false) && index === -1) {
-      return true
-    }
-    return false
+    return (this.options.vertices.middle === false || this.options.vertices.insert === false) && index === -1
   }
 
   /**
@@ -455,7 +452,6 @@ class OrsExtendedPolyline {
   /**
    * Process the polyline drag by adding a temporary
    * vertex to represent user drag action
-   * @param {*} event
    */
   processDrag () {
     const closestIndex = this._getClosestIndex()

src/fragments/map-view/map-definitions.js

@@ -5,12 +5,12 @@ import store from '@/store/store'
 const mapDefinitions = {
   /**
    * Reorder the values of an array of coordinates switching the position of lat and long of each coordinate
-   * @param {*} coordinatesArr
    * @returns {Array} of reordered coordinates
+   * @param polylineMeasureTranslations
    */
   polylineMeasureOptions: (polylineMeasureTranslations) => {
     // eslint-disable-block no-multi-spaces
-    const options = {
+    return {
       // language options
       ...polylineMeasureTranslations,
       // other options
@@ -58,7 +58,6 @@ const mapDefinitions = {
         radius: 6 // Radius of the circle
       }
     }
-    return options
   },
   /**
    * Build the draw options object