Validate format flag in PreRun

Signed-off-by: Lucas Bremgartner <[email protected]>

Author: breml

cmd/migration-manager/cmds/batch.go

@@ -179,7 +179,10 @@ func (c *cmdBatchList) Command() *cobra.Command {
 `
 
 	cmd.RunE = c.Run
-	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", "Format (csv|json|table|yaml|compact)")
+	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", `Format (csv|json|table|yaml|compact), use suffix ",noheader" to disable headers and ",header" to enable if demanded, e.g. csv,header`)
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
+		return validateFlagFormat(cmd.Flag("format").Value.String())
+	}
 
 	return cmd
 }

cmd/migration-manager/cmds/instance.go

@@ -60,8 +60,11 @@ func (c *cmdInstanceList) Command() *cobra.Command {
 `
 
 	cmd.RunE = c.Run
-	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", "Format (csv|json|table|yaml|compact)")
+	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", `Format (csv|json|table|yaml|compact), use suffix ",noheader" to disable headers and ",header" to enable if demanded, e.g. csv,header`)
 	cmd.Flags().BoolVarP(&c.flagVerbose, "verbose", "", false, "Enable verbose output")
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
+		return validateFlagFormat(cmd.Flag("format").Value.String())
+	}
 
 	return cmd
 }

cmd/migration-manager/cmds/network.go

@@ -125,7 +125,10 @@ func (c *cmdNetworkList) Command() *cobra.Command {
 `
 
 	cmd.RunE = c.Run
-	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", "Format (csv|json|table|yaml|compact)")
+	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", `Format (csv|json|table|yaml|compact), use suffix ",noheader" to disable headers and ",header" to enable if demanded, e.g. csv,header`)
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
+		return validateFlagFormat(cmd.Flag("format").Value.String())
+	}
 
 	return cmd
 }

cmd/migration-manager/cmds/queue.go

@@ -53,8 +53,11 @@ func (c *cmdQueueList) Command() *cobra.Command {
 `
 
 	cmd.RunE = c.Run
-	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", "Format (csv|json|table|yaml|compact)")
+	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", `Format (csv|json|table|yaml|compact), use suffix ",noheader" to disable headers and ",header" to enable if demanded, e.g. csv,header`)
 	cmd.Flags().BoolVarP(&c.flagVerbose, "verbose", "", false, "Enable verbose output")
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
+		return validateFlagFormat(cmd.Flag("format").Value.String())
+	}
 
 	return cmd
 }

cmd/migration-manager/cmds/source.go

@@ -187,7 +187,10 @@ func (c *cmdSourceList) Command() *cobra.Command {
 `
 
 	cmd.RunE = c.Run
-	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", "Format (csv|json|table|yaml|compact)")
+	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", `Format (csv|json|table|yaml|compact), use suffix ",noheader" to disable headers and ",header" to enable if demanded, e.g. csv,header`)
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
+		return validateFlagFormat(cmd.Flag("format").Value.String())
+	}
 
 	return cmd
 }

cmd/migration-manager/cmds/target.go

@@ -183,7 +183,10 @@ func (c *cmdTargetList) Command() *cobra.Command {
 `
 
 	cmd.RunE = c.Run
-	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", "Format (csv|json|table|yaml|compact)")
+	cmd.Flags().StringVarP(&c.flagFormat, "format", "f", "table", `Format (csv|json|table|yaml|compact), use suffix ",noheader" to disable headers and ",header" to enable if demanded, e.g. csv,header`)
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
+		return validateFlagFormat(cmd.Flag("format").Value.String())
+	}
 
 	return cmd
 }

cmd/migration-manager/cmds/validate_flags.go

@@ -0,0 +1,31 @@
+package cmds
+
+import (
+	"fmt"
+	"strings"
+)
+
+func validateFlagFormat(value string) error {
+	fields := strings.SplitN(value, ",", 2)
+	format := fields[0]
+
+	var options []string
+	if len(fields) == 2 {
+		options = strings.Split(fields[1], ",")
+		for _, option := range options {
+			switch option {
+			case "noheader", "header":
+			default:
+				return fmt.Errorf(`Invalid value for flag "--format": %q`, format)
+			}
+		}
+	}
+
+	switch format {
+	case "csv", "json", "table", "yaml", "compact":
+	default:
+		return fmt.Errorf(`Invalid value for flag "--format": %q`, format)
+	}
+
+	return nil
+}