Skip to content

Commit ead3dc3

Browse files
[BUGFIX] Do not enforce UTF-8 encoding when copying font files
With the upgrade to Gulp v5 in 8904162, copying font files broke as result of a breaking in Gulp itself – streams are encoded to UTF-8 by default [1], breaking the font files. The explicit encoding is now disabled again, fixing the font files as proven by comparing their checksums: ``` sha1sum Build/node_modules/font-awesome/fonts/* Resources/Public/Fonts/* 048707bc52ac4b6563aaa383bfe8660a0ddc908c Build/node_modules/font-awesome/fonts/FontAwesome.otf d980c2ce873dc43af460d4d572d441304499f400 Build/node_modules/font-awesome/fonts/fontawesome-webfont.eot 98a8aa5cf7d62c2eff5f07ede8d844b874ef06ed Build/node_modules/font-awesome/fonts/fontawesome-webfont.svg 13b1eab65a983c7a73bc7997c479d66943f7c6cb Build/node_modules/font-awesome/fonts/fontawesome-webfont.ttf 28b782240b3e76db824e12c02754a9731a167527 Build/node_modules/font-awesome/fonts/fontawesome-webfont.woff d6f48cba7d076fb6f2fd6ba993a75b9dc1ecbf0c Build/node_modules/font-awesome/fonts/fontawesome-webfont.woff2 048707bc52ac4b6563aaa383bfe8660a0ddc908c Resources/Public/Fonts/FontAwesome.otf d980c2ce873dc43af460d4d572d441304499f400 Resources/Public/Fonts/fontawesome-webfont.eot 98a8aa5cf7d62c2eff5f07ede8d844b874ef06ed Resources/Public/Fonts/fontawesome-webfont.svg 13b1eab65a983c7a73bc7997c479d66943f7c6cb Resources/Public/Fonts/fontawesome-webfont.ttf 28b782240b3e76db824e12c02754a9731a167527 Resources/Public/Fonts/fontawesome-webfont.woff d6f48cba7d076fb6f2fd6ba993a75b9dc1ecbf0c Resources/Public/Fonts/fontawesome-webfont.woff2 ``` [1] https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md#500-2024-03-29
1 parent e43c534 commit ead3dc3

File tree

8 files changed

+36
-38
lines changed

8 files changed

+36
-38
lines changed

Build/gulpfile.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
const { pipeline } = require('node:stream/promises');
34
const {src, dest, parallel} = require('gulp');
45
const sass = require('gulp-sass')(require('sass'));
56
const concat = require('gulp-concat');
@@ -12,7 +13,7 @@ function buildStyles() {
1213
}
1314

1415
function copyFonts() {
15-
return src('node_modules/font-awesome/fonts/*')
16+
return src('node_modules/font-awesome/fonts/*', {encoding: false})
1617
.pipe(dest('../Resources/Public/Fonts'));
1718
}
1819

Build/package-lock.json

Lines changed: 33 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Build/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"font-awesome": "^4.7.0"
1212
},
1313
"devDependencies": {
14-
"gulp": "^5.0.0",
14+
"gulp": "^5.0.1",
1515
"gulp-concat": "^2.6.1",
1616
"gulp-sass": "^5.1.0",
1717
"sass": "^1.54.0"
-121 KB
Binary file not shown.
-45.7 KB
Binary file not shown.
-45.7 KB
Binary file not shown.
-77.6 KB
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)