Update coding standards

stof · stof · commit 05480c553513 · 2024-06-24T11:11:06.000+02:00
diff --git a/Controller/SecurityController.php b/Controller/SecurityController.php
@@ -29,7 +29,7 @@ class SecurityController extends AbstractController
     private $authenticationUtils;
     private $tokenManager;
 
-    public function __construct(AuthenticationUtils $authenticationUtils, CsrfTokenManagerInterface $tokenManager = null)
+    public function __construct(AuthenticationUtils $authenticationUtils, ?CsrfTokenManagerInterface $tokenManager = null)
     {
         $this->authenticationUtils = $authenticationUtils;
         $this->tokenManager = $tokenManager;
diff --git a/Event/UserEvent.php b/Event/UserEvent.php
@@ -27,7 +27,7 @@ class UserEvent extends Event
      */
     protected $user;
 
-    public function __construct(UserInterface $user, Request $request = null)
+    public function __construct(UserInterface $user, ?Request $request = null)
     {
         $this->user = $user;
         $this->request = $request;
diff --git a/Form/Factory/FormFactory.php b/Form/Factory/FormFactory.php
@@ -43,7 +43,7 @@ class FormFactory implements FactoryInterface
      * @param string        $type
      * @param string[]|null $validationGroups
      */
-    public function __construct(FormFactoryInterface $formFactory, $name, $type, array $validationGroups = null)
+    public function __construct(FormFactoryInterface $formFactory, $name, $type, ?array $validationGroups = null)
     {
         $this->formFactory = $formFactory;
         $this->name = $name;
diff --git a/Model/User.php b/Model/User.php
@@ -353,7 +353,7 @@ public function setPlainPassword($password)
         return $this;
     }
 
-    public function setLastLogin(\DateTime $time = null)
+    public function setLastLogin(?\DateTime $time = null)
     {
         $this->lastLogin = $time;
 
@@ -367,7 +367,7 @@ public function setConfirmationToken($confirmationToken)
         return $this;
     }
 
-    public function setPasswordRequestedAt(\DateTime $date = null)
+    public function setPasswordRequestedAt(?\DateTime $date = null)
     {
         $this->passwordRequestedAt = $date;
 
diff --git a/Model/UserInterface.php b/Model/UserInterface.php
@@ -191,7 +191,7 @@ public function setConfirmationToken($confirmationToken);
      *
      * @return static
      */
-    public function setPasswordRequestedAt(\DateTime $date = null);
+    public function setPasswordRequestedAt(?\DateTime $date = null);
 
     /**
      * Checks whether the password reset request has expired.
@@ -207,7 +207,7 @@ public function isPasswordRequestNonExpired($ttl);
      *
      * @return static
      */
-    public function setLastLogin(\DateTime $time = null);
+    public function setLastLogin(?\DateTime $time = null);
 
     /**
      * Never use this to check if this user has access to anything!
diff --git a/Security/LoginManager.php b/Security/LoginManager.php
@@ -73,7 +73,7 @@ public function __construct(TokenStorageInterface $tokenStorage, UserCheckerInte
         $this->rememberMeHandler = $rememberMeHandler;
     }
 
-    final public function logInUser($firewallName, UserInterface $user, Response $response = null): void
+    final public function logInUser($firewallName, UserInterface $user, ?Response $response = null): void
     {
         $this->userChecker->checkPreAuth($user);
 
diff --git a/Security/LoginManagerInterface.php b/Security/LoginManagerInterface.php
@@ -21,5 +21,5 @@ interface LoginManagerInterface
      *
      * @return void
      */
-    public function logInUser($firewallName, UserInterface $user, Response $response = null);
+    public function logInUser($firewallName, UserInterface $user, ?Response $response = null);
 }
diff --git a/Tests/Command/ActivateUserCommandTest.php b/Tests/Command/ActivateUserCommandTest.php
@@ -60,7 +60,7 @@ public function testExecuteInteractiveWithQuestionHelper()
     /**
      * @return CommandTester
      */
-    private function createCommandTester(UserManipulator $manipulator, Application $application = null)
+    private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)
     {
         if (null === $application) {
             $application = new Application();
diff --git a/Tests/Command/ChangePasswordCommandTest.php b/Tests/Command/ChangePasswordCommandTest.php
@@ -61,7 +61,7 @@ public function testExecuteInteractiveWithQuestionHelper()
     /**
      * @return CommandTester
      */
-    private function createCommandTester(UserManipulator $userManipulator, Application $application = null)
+    private function createCommandTester(UserManipulator $userManipulator, ?Application $application = null)
     {
         if (null === $application) {
             $application = new Application();
diff --git a/Tests/Command/CreateUserCommandTest.php b/Tests/Command/CreateUserCommandTest.php
@@ -64,7 +64,7 @@ public function testExecuteInteractiveWithQuestionHelper()
     /**
      * @return CommandTester
      */
-    private function createCommandTester(UserManipulator $manipulator, Application $application = null)
+    private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)
     {
         if (null === $application) {
             $application = new Application();
diff --git a/Tests/Command/DeactivateUserCommandTest.php b/Tests/Command/DeactivateUserCommandTest.php
@@ -60,7 +60,7 @@ public function testExecuteInteractiveWithQuestionHelper()
     /**
      * @return CommandTester
      */
-    private function createCommandTester(UserManipulator $manipulator, Application $application = null)
+    private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)
     {
         if (null === $application) {
             $application = new Application();
diff --git a/Tests/Command/DemoteUserCommandTest.php b/Tests/Command/DemoteUserCommandTest.php
@@ -61,7 +61,7 @@ public function testExecuteInteractiveWithQuestionHelper()
     /**
      * @return CommandTester
      */
-    private function createCommandTester(UserManipulator $manipulator, Application $application = null)
+    private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)
     {
         if (null === $application) {
             $application = new Application();
diff --git a/Tests/Command/PromoteUserCommandTest.php b/Tests/Command/PromoteUserCommandTest.php
@@ -61,7 +61,7 @@ public function testExecuteInteractiveWithQuestionHelper()
     /**
      * @return CommandTester
      */
-    private function createCommandTester(UserManipulator $manipulator, Application $application = null)
+    private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)
     {
         if (null === $application) {
             $application = new Application();

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class SecurityController extends AbstractController`
`29`	`29`	`private $authenticationUtils;`
`30`	`30`	`private $tokenManager;`
`31`	`31`
`32`		`- public function __construct(AuthenticationUtils $authenticationUtils, CsrfTokenManagerInterface $tokenManager = null)`
	`32`	`+ public function __construct(AuthenticationUtils $authenticationUtils, ?CsrfTokenManagerInterface $tokenManager = null)`
`33`	`33`	`{`
`34`	`34`	`$this->authenticationUtils = $authenticationUtils;`
`35`	`35`	`$this->tokenManager = $tokenManager;`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ class UserEvent extends Event`
`27`	`27`	`*/`
`28`	`28`	`protected $user;`
`29`	`29`
`30`		`- public function __construct(UserInterface $user, Request $request = null)`
	`30`	`+ public function __construct(UserInterface $user, ?Request $request = null)`
`31`	`31`	`{`
`32`	`32`	`$this->user = $user;`
`33`	`33`	`$this->request = $request;`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class FormFactory implements FactoryInterface`
`43`	`43`	`* @param string $type`
`44`	`44`	`* @param string[]\|null $validationGroups`
`45`	`45`	`*/`
`46`		`- public function __construct(FormFactoryInterface $formFactory, $name, $type, array $validationGroups = null)`
	`46`	`+ public function __construct(FormFactoryInterface $formFactory, $name, $type, ?array $validationGroups = null)`
`47`	`47`	`{`
`48`	`48`	`$this->formFactory = $formFactory;`
`49`	`49`	`$this->name = $name;`
Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ public function setPlainPassword($password)`
`353`	`353`	`return $this;`
`354`	`354`	`}`
`355`	`355`
`356`		`- public function setLastLogin(\DateTime $time = null)`
	`356`	`+ public function setLastLogin(?\DateTime $time = null)`
`357`	`357`	`{`
`358`	`358`	`$this->lastLogin = $time;`
`359`	`359`
`@@ -367,7 +367,7 @@ public function setConfirmationToken($confirmationToken)`
`367`	`367`	`return $this;`
`368`	`368`	`}`
`369`	`369`
`370`		`- public function setPasswordRequestedAt(\DateTime $date = null)`
	`370`	`+ public function setPasswordRequestedAt(?\DateTime $date = null)`
`371`	`371`	`{`
`372`	`372`	`$this->passwordRequestedAt = $date;`
`373`	`373`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function __construct(TokenStorageInterface $tokenStorage, UserCheckerInte`
`73`	`73`	`$this->rememberMeHandler = $rememberMeHandler;`
`74`	`74`	`}`
`75`	`75`
`76`		`- final public function logInUser($firewallName, UserInterface $user, Response $response = null): void`
	`76`	`+ final public function logInUser($firewallName, UserInterface $user, ?Response $response = null): void`
`77`	`77`	`{`
`78`	`78`	`$this->userChecker->checkPreAuth($user);`
`79`	`79`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,5 @@ interface LoginManagerInterface`
`21`	`21`	`*`
`22`	`22`	`* @return void`
`23`	`23`	`*/`
`24`		`- public function logInUser($firewallName, UserInterface $user, Response $response = null);`
	`24`	`+ public function logInUser($firewallName, UserInterface $user, ?Response $response = null);`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function testExecuteInteractiveWithQuestionHelper()`
`60`	`60`	`/**`
`61`	`61`	`* @return CommandTester`
`62`	`62`	`*/`
`63`		`- private function createCommandTester(UserManipulator $manipulator, Application $application = null)`
	`63`	`+ private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)`
`64`	`64`	`{`
`65`	`65`	`if (null === $application) {`
`66`	`66`	`$application = new Application();`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function testExecuteInteractiveWithQuestionHelper()`
`61`	`61`	`/**`
`62`	`62`	`* @return CommandTester`
`63`	`63`	`*/`
`64`		`- private function createCommandTester(UserManipulator $userManipulator, Application $application = null)`
	`64`	`+ private function createCommandTester(UserManipulator $userManipulator, ?Application $application = null)`
`65`	`65`	`{`
`66`	`66`	`if (null === $application) {`
`67`	`67`	`$application = new Application();`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public function testExecuteInteractiveWithQuestionHelper()`
`64`	`64`	`/**`
`65`	`65`	`* @return CommandTester`
`66`	`66`	`*/`
`67`		`- private function createCommandTester(UserManipulator $manipulator, Application $application = null)`
	`67`	`+ private function createCommandTester(UserManipulator $manipulator, ?Application $application = null)`
`68`	`68`	`{`
`69`	`69`	`if (null === $application) {`
`70`	`70`	`$application = new Application();`