fix: correct check in QueueChecker to consider empty queue

tinect · tinect · commit cf9f2117f556 · 2022-04-25T11:45:47.000+02:00
diff --git a/CHANGELOG_de-DE.md b/CHANGELOG_de-DE.md
@@ -31,3 +31,7 @@
 * Show IndexerName for TaskLogger
 * Add manager for Elasticsearch
 * Add performance checks
+
+# 0.1.5
+
+* Fix QueueChecker to show correct message
diff --git a/CHANGELOG_en-GB.md b/CHANGELOG_en-GB.md
@@ -31,3 +31,7 @@
 * Show IndexerName for TaskLogger
 * Add manager for Elasticsearch
 * Add performance checks
+
+# 0.1.5
+
+* Fix QueueChecker to show correct message
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
     "name": "frosh/tools",
-    "version": "0.1.4",
+    "version": "0.1.5",
     "description": "Provides some basic things for managing the Shopware Installation",
     "type": "shopware-platform-plugin",
     "license": "MIT",
diff --git a/src/Components/Health/Checker/HealthChecker/QueueChecker.php b/src/Components/Health/Checker/HealthChecker/QueueChecker.php
@@ -25,7 +25,7 @@ public function collect(HealthCollection $collection): void
         $minutes = 15;
 
         // When the oldest message is older then $minutes minutes
-        if (($oldestMessage + ($minutes * 60)) < time()) {
+        if ($oldestMessage && ($oldestMessage + ($minutes * 60)) < time()) {
             $result = SettingsResult::warning('frosh-tools.checker.queuesWarning');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "frosh/tools",`
`3`		`- "version": "0.1.4",`
	`3`	`+ "version": "0.1.5",`
`4`	`4`	`"description": "Provides some basic things for managing the Shopware Installation",`
`5`	`5`	`"type": "shopware-platform-plugin",`
`6`	`6`	`"license": "MIT",`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public function collect(HealthCollection $collection): void`
`25`	`25`	`$minutes = 15;`
`26`	`26`
`27`	`27`	`// When the oldest message is older then $minutes minutes`
`28`		`- if (($oldestMessage + ($minutes * 60)) < time()) {`
	`28`	`+ if ($oldestMessage && ($oldestMessage + ($minutes * 60)) < time()) {`
`29`	`29`	`$result = SettingsResult::warning('frosh-tools.checker.queuesWarning');`
`30`	`30`	`}`
`31`	`31`