fix: rector

Author: stefanpoensgen

src/Command/MonitorCommand.php

@@ -3,6 +3,7 @@
 
 namespace Frosh\Tools\Command;
 
+use Shopware\Core\Content\Mail\Service\MailService;
 use Doctrine\DBAL\Connection;
 use Shopware\Core\Content\Mail\Service\AbstractMailService;
 use Shopware\Core\Framework\Context;
@@ -29,7 +30,7 @@ class MonitorCommand extends Command
     private const MONITOR_SALESCHANNEL_ARG = 'sales-channel';
 
     public function __construct(
-        #[Autowire(service: 'Shopware\Core\Content\Mail\Service\MailService')] private readonly AbstractMailService $mailService,
+        #[Autowire(service: MailService::class)] private readonly AbstractMailService $mailService,
         private readonly SystemConfigService $configService,
         private readonly Connection $connection,
         private readonly EntityRepository $scheduledTaskRepository

src/Components/Environment/EnvironmentFile.php

@@ -25,7 +25,7 @@ public function __toString(): string
 
     public function has(string $key): bool
     {
-        return $this->get($key) !== null;
+        return $this->get($key) instanceof EnvironmentKeyValue;
     }
 
     public function get(string $key): ?EnvironmentKeyValue
@@ -43,7 +43,7 @@ public function set(string $key, string $value): void
     {
         $v = $this->get($key);
 
-        if ($v !== null) {
+        if ($v instanceof EnvironmentKeyValue) {
             $v->setValue($value);
 
             return;

src/Components/Health/Checker/HealthChecker/TaskChecker.php

@@ -41,9 +41,7 @@ public function collect(HealthCollection $collection): void
         $taskDateLimit = (new \DateTimeImmutable())->modify(\sprintf('-%d minutes', $maxDiff));
         $recommended = \sprintf('max %d mins', $maxDiff);
 
-        $tasks = array_filter($tasks, function (array $task) use ($taskDateLimit) {
-            return new \DateTimeImmutable($task['next_execution_time']) < $taskDateLimit;
-        });
+        $tasks = array_filter($tasks, fn(array $task) => new \DateTimeImmutable($task['next_execution_time']) < $taskDateLimit);
 
         if ($tasks === []) {
             $collection->add(SettingsResult::ok('scheduled_task', 'Scheduled tasks', '0 mins', $recommended));

src/Components/StateMachines/Plantuml.php

@@ -11,7 +11,7 @@ final class Plantuml implements ExportInterface
 {
     private const DEFAULT_PATH = __DIR__ . '/../../Resources/views/administration/plantuml';
 
-    private Environment $twig;
+    private readonly Environment $twig;
 
     public function __construct()
     {

src/Controller/StateMachineController.php

@@ -17,7 +17,7 @@
 #[Route(path: '/api/_action/frosh-tools', defaults: ['_routeScope' => ['api'], '_acl' => ['frosh_tools:read']])]
 final class StateMachineController extends AbstractController
 {
-    public function __construct(private EntityRepository $stateMachineRepository)
+    public function __construct(private readonly EntityRepository $stateMachineRepository)
     {
     }