Added if statement to check if thumbnails are set

[jesse-deboer]

This change will solve a bug that will happen when there is no first.width available.

The code will now add one image in the src-set with 1w, which does not work in Safari on the iPad and with this change it will not add any src-set if there are no images available to put in there.

[tinect]

Hi @jesse-deboer
how can the width be not available? Iirc, thumbnails are always based on width and height.

Edit: oh, I see.
This happens when the filter before result into an empty list.

Could please check for thumbnails has content instead and adjust the check in line 45? So, a reader has more context for understanding.

[jesse-deboer]

I updated it!

It gives you an empty list when the metaData.width is smaller than the v.width because the filter won't get any values

[jesse-deboer]

Also updated line 45 now 😄

[tinect]

Also updated line 45 now 😄

Thank you. But line 45 is one line above. In your current way, there would be 3 more useless attributes set.

https://github.com/FriendsOfShopware/FroshPlatformThumbnailProcessor/pull/30/files#diff-902f09bb96e2c21965cf4b3e2affebe058357695c767cc97945146c6761e5d41R45