Make sure description isn't null when extracting chapters from description #7505
Conversation
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
Before we do a fix to just make the error go away, we should check that the description is actually completely missing in those responses or whether it has been moved to somewhere else in the response structure, in which case we should extract it from the new location. My suspicion is that it is the latter (yt-dlp has had reports recently about the translated title not being extracted, which sounds related) and an A/B test which would explain why it can't be reproduced consistently.
Unfortunately @efb4f5ff-1298-471a-8973-3d47447115dc wasn't able to reproduce it with the devtools attached, so we currently only have the error message (in electron/chromium logs are captured all the time, requests and responses are only captured while devtools are open).
I'm not blocking this pull request entirely, I just want to be sure that this is the right fix. If we don't have an answer right before we do the next release, I am happy to approve it as-is so that users don't see the error.
|
I've caught the error again and shared the responses |
|
Looks like it has a placeholder (descriptionPlaceholder) saying that the description is empty now: {
"expandableVideoDescriptionBodyRenderer": {
"descriptionPlaceholder": {
"content": "No description has been added to this video.",
"styleRuns": [
{
"startIndex": 0,
"fontColor": 4284506208,
"italic": true
}
]
}
}
}, |
|
As it looks like the description is actually missing and it seems like YouTube is just switching how they handle videos without a description, I'll remove my block. |
|
Got this message
|
Pull Request Type
Related issue
closes #7503
Description
result.basic_info.short_description and result.secondary_info.description.text are both nullable strings and for whatever reason both returned null from Rune's testing
Testing
Desktop