Skip to content

[Bug]: FreeTube crashes when being maximized or fullscreened (Wayland) #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 6 tasks
pm4rcin opened this issue Jun 21, 2024 · 6 comments
Closed
5 of 6 tasks
Labels
B: crash bug Something isn't working electron being electron Electron related bugs and trickeries OS: linux issue that occurs on linux but not on other platforms

Comments

@pm4rcin
Copy link

pm4rcin commented Jun 21, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Open app
  2. Maximize app or video
  3. Observe window crash

Expected Behavior

App should function normally when being maximized.

Issue Labels

causes crash

FreeTube Version

v0.21.0

Operating System Version

Fedora Sway Atomic 40

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

0.20.0

Additional Information

Started with flags for wayland on Hyprland 0.39.1

Nightly Build

@pm4rcin pm4rcin added the bug Something isn't working label Jun 21, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the OS: linux issue that occurs on linux but not on other platforms label Jun 21, 2024
@Zeabyte
Copy link
Contributor

Zeabyte commented Jun 22, 2024

Does this happen for you with stock flatpak options? Meaning on x11. I can only reproduce this on wayland with the following command:

flatpak run --socket=wayland io.freetubeapp.FreeTube --enable-features=UseOzonePlatform --ozone-platform=wayland

With this I have the same problem. With stock config, without wayland support, it works.

@kommunarr kommunarr added the electron being electron Electron related bugs and trickeries label Jun 22, 2024
@kommunarr
Copy link
Collaborator

See electron/electron#42560.

@kommunarr kommunarr changed the title [Bug]: FreeTube crashes when being maximized [Bug]: FreeTube crashes when being maximized or fullscreened (Wayland) Jun 24, 2024
@muelsyse-az
Copy link

This has mysteriously been fixed with the 0.21.1 update. (The unusual configuration here is due to trying a workaround for a separate issue. This workaround still caused a crash when fullscreen on <0.21.1)

Info: Fedora Kinoite 40, Flatpak version, forced Wayland through flatpak permissions system (+ ELECTRON_OZONE_PLATFORM_HINT = auto)

Can someone confirm?

@jmcelroy01
Copy link

This has mysteriously been fixed with the 0.21.1 update. (The unusual configuration here is due to trying a workaround for a separate issue. This workaround still caused a crash when fullscreen on <0.21.1)

Info: Fedora Kinoite 40, Flatpak version, forced Wayland through flatpak permissions system (+ ELECTRON_OZONE_PLATFORM_HINT = auto)

Can someone confirm?

It is fixed for me as well on Gentoo/Hyprland/Flatpak, no forced permission though.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 11, 2024

We have updated Electron twice so that maybe did the trick (havent look through their changelog yet to verify this. Feel free to check it yourself)

See #5355 and #5328

@pm4rcin
Copy link
Author

pm4rcin commented Jul 11, 2024

Hard to tell which release fixed it or maybe even chromium bump in Electron. I'll close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: crash bug Something isn't working electron being electron Electron related bugs and trickeries OS: linux issue that occurs on linux but not on other platforms
Projects
None yet
Development

No branches or pull requests

6 participants