Skip to content

[Bug]: Same video can start playing twice, as separate instances #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
stdedos opened this issue May 28, 2024 · 4 comments · Fixed by #4978
Closed
6 tasks done

[Bug]: Same video can start playing twice, as separate instances #5187

stdedos opened this issue May 28, 2024 · 4 comments · Fixed by #4978
Labels
B: inconsistent behavior bug Something isn't working player-related Player-related changes are currently on hold due to the ongoing player migration.

Comments

@stdedos
Copy link

stdedos commented May 28, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Open a video
  2. Play it midway
  3. Switch to PiP
  4. Go to Settings
  5. Press the back button in the browser

Expected Behavior

  • The previous page is loaded
  • Main video player is "frozen", showing "Playing in PiP"
  • PiP is still playing
  • PiP buttons control the (single) source of sound
  • "Back to Tab" returns the video to the main window

Issue Labels

inconsistent behavior

FreeTube Version

v0.20.0 Beta

Operating System Version

Ubuntu 20.04.6

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

https://github.com/FreeTubeApp/FreeTube/issues?page=2&q=is%3Aissue+two+videos+playing

image

Nightly Build
@stdedos stdedos added the bug Something isn't working label May 28, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Ah so its still an issue. First reported in #2041 but was closed due to inactivity of the OP

@stdedos
Copy link
Author

stdedos commented May 31, 2024

I mean, his repro is "somewhat complicated", but I guess I get that after 1y he sort of "didn't bother retrying" 😅

I mean - I am not "exactly trying" to arrive to this state either. But at least I'll be able to repro it quite easily.

@kommunarr kommunarr added the player-related Player-related changes are currently on hold due to the ongoing player migration. label Jun 24, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B: inconsistent behavior bug Something isn't working player-related Player-related changes are currently on hold due to the ongoing player migration.
Projects
Bug Reports
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate video player from video.js to shaka-player absidue/FreeTube
3 participants
@stdedos @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr