Fix "Open in new window" context menu action in release builds (#2873)

absidue · web-flow · commit c8d37cd55251 · 2022-11-21T22:29:24.000+01:00
* Fix "Open in new window" context menu action in release builds

* Better check and add comment
diff --git a/src/main/index.js b/src/main/index.js
@@ -31,7 +31,8 @@ function runApp() {
       },
       {
         label: 'Open in a New Window',
-        visible: parameters.linkURL.includes((new URL(browserWindow.webContents.getURL())).origin),
+        // Only show the option for in-app URLs and not external ones
+        visible: parameters.linkURL.split('#')[0] === browserWindow.webContents.getURL().split('#')[0],
         click: () => {
           createWindow({ replaceMainWindow: false, windowStartupUrl: parameters.linkURL, showWindowNow: true })
         }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@ function runApp() {`
`31`	`31`	`},`
`32`	`32`	`{`
`33`	`33`	`label: 'Open in a New Window',`
`34`		`- visible: parameters.linkURL.includes((new URL(browserWindow.webContents.getURL())).origin),`
	`34`	`+ // Only show the option for in-app URLs and not external ones`
	`35`	`+ visible: parameters.linkURL.split('#')[0] === browserWindow.webContents.getURL().split('#')[0],`
`35`	`36`	`click: () => {`
`36`	`37`	`createWindow({ replaceMainWindow: false, windowStartupUrl: parameters.linkURL, showWindowNow: true })`
`37`	`38`	`}`