Add font-display to eliminate Lighthouse warning (#110)

Author: robmadole

includes/class-fontawesome.php

@@ -1716,6 +1716,7 @@ function () use ( $resources, $options, $version ) {
 							$font_face = <<< EOT
 @font-face {
 font-family: "FontAwesome";
+font-display: block;
 src: url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-brands-400.eot"),
 		url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-brands-400.eot?#iefix") format("embedded-opentype"),
 		url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-brands-400.woff2") format("woff2"),
@@ -1726,6 +1727,7 @@ function () use ( $resources, $options, $version ) {
 
 @font-face {
 font-family: "FontAwesome";
+font-display: block;
 src: url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-solid-900.eot"),
 		url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-solid-900.eot?#iefix") format("embedded-opentype"),
 		url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-solid-900.woff2") format("woff2"),
@@ -1736,6 +1738,7 @@ function () use ( $resources, $options, $version ) {
 
 @font-face {
 font-family: "FontAwesome";
+font-display: block;
 src: url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-regular-400.eot"),
 		url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-regular-400.eot?#iefix") format("embedded-opentype"),
 		url("https://${license_subdomain}.fontawesome.com/releases/v${version}/webfonts/fa-regular-400.woff2") format("woff2"),

tests/test-enqueue.php

@@ -147,7 +147,7 @@ public function assert_font_face_inline_style_detection_ignore($output, $refute
 
 	public function assert_font_face_overrides($output, $license_subdomain, $version, $refute = false){
 		$font_face_match_count = preg_match_all(
-			"/@font-face {\n.*?font-family: \"FontAwesome\";\n[\s]*src: url\(\"https:\/\/${license_subdomain}\.fontawesome\.com.*?${version}\/webfonts\/fa-brands-400\.eot\"/",
+			"/@font-face {\n.*?font-family: \"FontAwesome\";\n.*?font-display: block;\n[\s]*src: url\(\"https:\/\/${license_subdomain}\.fontawesome\.com.*?${version}\/webfonts\/fa-brands-400\.eot\"/",
 			$output,
 			$font_face_matches
 		);