Fordoxia
diff --git a/‎.github/CODEOWNERS
Lines changed: 5 additions & 0 deletions b/‎.github/CODEOWNERS
Lines changed: 5 additions & 0 deletions
diff --git a/‎.github/CONTRIBUTING.md
Lines changed: 31 additions & 2 deletions b/‎.github/CONTRIBUTING.md
Lines changed: 31 additions & 2 deletions
diff --git a/‎.github/assets/book-dark.png
5.89 KB b/‎.github/assets/book-dark.png
5.89 KB
diff --git a/‎.github/assets/book-light.png
6.24 KB b/‎.github/assets/book-light.png
6.24 KB
diff --git a/‎.github/assets/compiles-sometimes.svg
Lines changed: 1 addition & 0 deletions b/‎.github/assets/compiles-sometimes.svg
Lines changed: 1 addition & 0 deletions
diff --git a/‎.github/assets/discord-dark.png
5.21 KB b/‎.github/assets/discord-dark.png
5.21 KB
diff --git a/‎.github/assets/discord-light.png
9.17 KB b/‎.github/assets/discord-light.png
9.17 KB
diff --git a/‎.github/assets/light-dark template.psd
149 KB b/‎.github/assets/light-dark template.psd
149 KB
diff --git a/‎.github/assets/made-in-byond.gif
22.8 KB b/‎.github/assets/made-in-byond.gif
22.8 KB
diff --git a/‎.github/assets/made-with-crayons.svg
Lines changed: 31 additions & 0 deletions b/‎.github/assets/made-with-crayons.svg
Lines changed: 31 additions & 0 deletions
diff --git a/‎.github/assets/paradise.png
7.27 KB b/‎.github/assets/paradise.png
7.27 KB
diff --git a/‎.github/assets/web-dark.png
6.12 KB b/‎.github/assets/web-dark.png
6.12 KB
diff --git a/‎.github/assets/web-light.png
12.2 KB b/‎.github/assets/web-light.png
12.2 KB
diff --git a/‎.github/assets/wiki-dark.png
7.08 KB b/‎.github/assets/wiki-dark.png
7.08 KB
diff --git a/‎.github/assets/wiki-light.png
12.5 KB b/‎.github/assets/wiki-light.png
12.5 KB
diff --git a/‎.github/workflows/merge_upstream_master.yml
Lines changed: 1 addition & 1 deletion b/‎.github/workflows/merge_upstream_master.yml
Lines changed: 1 addition & 1 deletion
diff --git a/‎.github/workflows/render_nanomaps.yml
Lines changed: 4 additions & 1 deletion b/‎.github/workflows/render_nanomaps.yml
Lines changed: 4 additions & 1 deletion
diff --git a/‎.tgs.yml
Lines changed: 1 addition & 1 deletion b/‎.tgs.yml
Lines changed: 1 addition & 1 deletion
diff --git a/‎COPYING
Lines changed: 0 additions & 19 deletions b/‎COPYING
Lines changed: 0 additions & 19 deletions
diff --git a/‎LICENSE-AGPL3.txt renamed to ‎LICENSE-AGPLv3.txt b/‎LICENSE-AGPL3.txt renamed to ‎LICENSE-AGPLv3.txt
@@ -26,3 +26,8 @@ _build_dependencies.sh @AffectedArc07
 dreamchecker.exe @AffectedArc07
 rust_g.dll @AffectedArc07
 librust_g.so @AffectedArc07
+
+### S34NW
+
+# TGUI stuff
+/tgui/bin @S34NW
@@ -157,15 +157,15 @@ if(thing == TRUE)
 	return "bleh"
 var/other_thing = pick(TRUE, FALSE)
 if(other_thing == FALSE)
-	return "meh"
+    return "meh"
 
 // Good
 var/thing = pick(TRUE, FALSE)
 if(thing)
 	return "bleh"
 var/other_thing = pick(TRUE, FALSE)
 if(!other_thing)
-	return "meh"
+    return "meh"
 ```
 
 ### Use `pick(x, y, z)`, not `pick(list(x, y, z))`
@@ -452,6 +452,32 @@ Look for code examples on how to properly use it.
     addtimer(CALLBACK(target, PROC_REF(dothing), arg1, arg2, arg3), 5 SECONDS)
 ```
 
+### Signals
+
+Signals are a slightly more advanced topic, but are often useful for attaching external behavior to objects that should be triggered when a specific event occurs.
+
+When defining procs that should be called by signals, you must include `SIGNAL_HANDLER` after the proc header. This ensures that no sleeping code can be called from within a signal handler, as that can cause problems with the signal system.
+
+Since callbacks can be connected to many signals with `RegisterSignal`, it can be difficult to pin down the source that a callback is invoked from. Any new `SIGNAL_HANDLER` should be followed by a comment listing the signals that the proc is expected to be invoked for. If there are multiple signals to be handled, separate them with a `+`.
+
+```dm
+/atom/movable/proc/when_moved(atom/movable/A)
+    SIGNAL_HANDLER  // COMSIG_MOVABLE_MOVED
+    do_something()
+
+/datum/component/foo/proc/on_enter(datum/source, atom/enterer)
+    SIGNAL_HANDLER  // COMSIG_ATOM_ENTERED + COMSIG_ATOM_INITIALIZED_ON
+    do_something_else()
+```
+
+If your proc does have something that needs to sleep (such as a `do_after()`), do not simply omit the `SIGNAL_HANDLER`. Instead, call the sleeping code with `INVOKE_ASYNC` from within the signal handling function.
+
+```dm
+/atom/movable/proc/when_moved(atom/movable/A)
+    SIGNAL_HANDLER  // COMSIG_MOVABLE_MOVED
+    INVOKE_ASYNC(src, PROC_REF(thing_that_sleeps), arg1)
+```
+
 ### Operators
 
 #### Spacing of operators
@@ -834,8 +860,10 @@ Each role inherits the lower role's responsibilities (IE: Headcoders also have c
 `Commit Access` members have write access to the repository and can merge your PRs. People included in this role are:
 
 - [AffectedArc07](https://github.com/AffectedArc07)
+- [Burzah](https://github.com/Burzah)
 - [Charliminator](https://github.com/hal9000PR)
 - [Contrabang](https://github.com/Contrabang)
+- [DGamerL](https://github.com/DGamerL)
 - [lewcc](https://github.com/lewcc)
 
 ---
@@ -846,6 +874,7 @@ Each role inherits the lower role's responsibilities (IE: Headcoders also have c
 - [Charliminator](https://github.com/hal9000PR)
 - [Contrabang](https://github.com/Contrabang)
 - [DGamerL](https://github.com/DGamerL)
+- [FunnyMan3595](https://github.com/FunnyMan3595)
 - [Henri215](https://github.com/Henri215)
 - [lewcc](https://github.com/lewcc)
 - [Sirryan2002](https://github.com/Sirryan2002)
 
@@ -101,7 +101,7 @@ jobs:
           # Check if a workflow file would be modified by the merge (permissions prevent pushes if so)
           latest_workflow_commit=$(git log -n 1 --pretty=format:"%H" upstream/$BASE_BRANCH -- .github/workflows)
           if ! git branch --contains $latest_workflow_commit | grep -q "$(git rev-parse --abbrev-ref HEAD)"; then
-            gh pr comment ${{ github.event.issue.html_url }} --body "GitHub Actions can not push to this branch as workflow files have been changed since your branch was last updated. Please update your branch past https://github.com/ParadiseSS13/Paradise/commit/$latest_workflow_commit before using this command again."#
+            gh pr comment ${{ github.event.issue.html_url }} --body "GitHub Actions can not push to this branch as workflow files have been changed since your branch was last updated. Please update your branch past https://github.com/ParadiseSS13/Paradise/commit/$latest_workflow_commit before using this command again."
             echo "FAIL_NOTIFIED=true" >> "$GITHUB_ENV"
             exit 1
           fi
 
@@ -43,4 +43,7 @@ jobs:
         git pull origin master
         git commit -m "NanoMap Auto-Update (`date`)" -a || true
         git push -f -u origin nanomap-render
-        gh pr create -t "Automatic NanoMap Update" -b "This pull request updates the server NanoMaps. Please review the diff images before merging." -l "NanoMaps" -H "nanomap-render" -B "master"
+        result=$(gh pr create -t "Automatic NanoMap Update" -b "This pull request updates the server NanoMaps. Please review the diff images before merging." -l "NanoMaps" -H "nanomap-render" -B "master")
+        if echo "$result" | grep -q "No commits between master and nanomap-render"
+          echo "No NanoMaps update required, skipping."
+          exit 78
@@ -3,7 +3,7 @@
 version: 1
 # The BYOND version to use
 # Must be interpreted as a string, keep quoted
-byond: "515.1620"
+byond: '515.1633'
 # Folders to create in "<instance_path>/Configuration/GameStaticFiles/"
 static_files:
   # Config directory should be static