Skip to content

[BUG] Provided file is ignored when upserting via API #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kennyakers opened this issue Nov 25, 2024 · 4 comments · Fixed by #3569
Closed

[BUG] Provided file is ignored when upserting via API #3560

kennyakers opened this issue Nov 25, 2024 · 4 comments · Fixed by #3569
Labels
bug Something isn't working in-work Issue in work

Comments

@kennyakers
Copy link

Describe the bug
When POSTing a file to the /vector/upsert/{id} endpoint, the provided file is ignored, and instead the file uploaded within the Flowise UI is upserted. In my case, I'm upserting PDFs to a Pinecone vector store. All credentials have been double-checked.

To Reproduce

An example upsertion flow is shown below:
Screenshot 2024-11-24 at 6 12 46 PM

Override config has been enabled so API calls should be able to overwrite the PDF file:
Screenshot 2024-11-24 at 6 26 25 PM

Note that the file originally uploaded is of the classic book Frankenstein. When I make a call to upsert a different book, Of Mice and Men, Frankenstein still ends up getting upserted (see response):
Screenshot 2024-11-24 at 6 17 01 PM

If I remove the file from the "PDF Loader" node, uploading any PDF (I even used the same Frankenstein file) to it will result in 0 documents getting upserted:
Screenshot 2024-11-24 at 6 14 26 PM

Expected behavior
The file provided in the form data should be upserted, not the file originally uploaded.

Setup

  • Installation: Repocloud.io instance
  • Flowise Version 2.1.5

Additional context
This only started becoming a problem ~3-4 weeks ago (i.e., beginning of November). It was working for months before then.

@ThijsObers
Copy link

ThijsObers commented Nov 25, 2024

I face the same issue as well. When I move back to version 2.1.3, it still works. (I have not tried 2.1.4 yet)

@HenryHengZJ
Copy link
Contributor

thanks for reporting, I knew something was missing! Fix is here: #3569, will be pushed to new release some time this week

@HenryHengZJ HenryHengZJ added bug Something isn't working in-work Issue in work labels Nov 25, 2024
@marsalan06
Copy link

any update on this issue ? the version 2.2.1 still has this bug :/

@kennyakers
Copy link
Author

any update on this issue ? the version 2.2.1 still has this bug :/

It appeared to be fixed briefly after upgrading to v2.2.1, but returned to the original behavior soon after.

After trying both the PDF loader and Unstructured loader (same result), the upsert history shows the 'files' parameter is never updated with the API-provided file -- perhaps the override config isn't taking effect here?

@HenryHengZJ hope that ^ context is useful. Appreciate all your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-work Issue in work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants