Bugfix/Sync Nodes (#2331)

HenryHengZJ · web-flow · commit af4e28aa91ff · 2024-05-06T12:41:46.000+01:00
add cloned nodes to avoid mutation on original nodes
diff --git a/packages/ui/src/views/canvas/index.jsx b/packages/ui/src/views/canvas/index.jsx
@@ -324,7 +324,8 @@ const Canvas = () => {
             const node = cloneNodes[i]
             const componentNode = componentNodes.find((cn) => cn.name === node.data.name)
             if (componentNode && componentNode.version > node.data.version) {
-                cloneNodes[i].data = updateOutdatedNodeData(componentNode, node.data)
+                const clonedComponentNode = cloneDeep(componentNode)
+                cloneNodes[i].data = updateOutdatedNodeData(clonedComponentNode, node.data)
                 toBeRemovedEdges.push(...updateOutdatedNodeEdge(cloneNodes[i].data, cloneEdges))
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,8 @@ const Canvas = () => {`
`324`	`324`	`const node = cloneNodes[i]`
`325`	`325`	`const componentNode = componentNodes.find((cn) => cn.name === node.data.name)`
`326`	`326`	`if (componentNode && componentNode.version > node.data.version) {`
`327`		`- cloneNodes[i].data = updateOutdatedNodeData(componentNode, node.data)`
	`327`	`+ const clonedComponentNode = cloneDeep(componentNode)`
	`328`	`+ cloneNodes[i].data = updateOutdatedNodeData(clonedComponentNode, node.data)`
`328`	`329`	`toBeRemovedEdges.push(...updateOutdatedNodeEdge(cloneNodes[i].data, cloneEdges))`
`329`	`330`	`}`
`330`	`331`	`}`