Fix found ESLint issues (#5771)

* autofix found ESLint issues

* remove unused references

Author: sosnovsky

eslint.config.mjs

@@ -1,19 +1,18 @@
 // Importing necessary ESLint plugins
-import typescriptEslint from 'typescript-eslint';
+import tseslint from 'typescript-eslint';
 import noOnlyTestsPlugin from 'eslint-plugin-no-only-tests';
 import headerPlugin from 'eslint-plugin-header';
 import jsdocPlugin from 'eslint-plugin-jsdoc';
 import preferArrowPlugin from 'eslint-plugin-prefer-arrow';
 import importPlugin from 'eslint-plugin-import';
 import noNullPlugin from 'eslint-plugin-no-null';
 import localRulesPlugin from 'eslint-plugin-local-rules';
-import globals from 'globals';
 import eslintConfigPrettier from 'eslint-config-prettier';
 import pluginJs from '@eslint/js';
 
 const commonConfig = {
   plugins: {
-    '@typescript-eslint': typescriptEslint.plugin,
+    '@typescript-eslint': tseslint.plugin,
     'no-only-tests': noOnlyTestsPlugin,
     header: headerPlugin,
     jsdoc: jsdocPlugin,
@@ -23,17 +22,9 @@ const commonConfig = {
     'local-rules': localRulesPlugin,
   },
   languageOptions: {
-    parser: typescriptEslint.parser,
-    sourceType: 'module',
-    ecmaVersion: 'latest',
-    globals: {
-      ...globals.browser,
-      ...globals.node,
-      ...globals.commonjs,
-      ...globals.es6,
-      $: false,
-      chrome: false,
-      OpenPGP: false,
+    parser: tseslint.parser,
+    parserOptions: {
+      project: true,
     },
   },
   rules: {
@@ -179,8 +170,8 @@ export default [
     ignores: ['extension/types/**', 'extension/js/common/core/types/**', 'test/source/core/types/**', 'build/**', 'extension/lib/**', 'eslint.config.js'],
   },
   pluginJs.configs.recommended,
-  ...typescriptEslint.configs.strictTypeChecked,
-  ...typescriptEslint.configs.stylisticTypeChecked,
+  ...tseslint.configs.strictTypeChecked,
+  ...tseslint.configs.stylisticTypeChecked,
   eslintConfigPrettier,
   {
     ...commonConfig,
@@ -220,7 +211,7 @@ export default [
       '@typescript-eslint/no-unsafe-member-access': 'off',
     },
   },
-  ...typescriptEslint.config({
+  ...tseslint.config({
     files: ['extension/js/content_scripts/webmail/**/*.ts'],
     languageOptions: {
       parserOptions: {

extension/js/common/api/key-server/attester.ts

@@ -28,9 +28,8 @@ export class Attester extends Api {
     ]);
     const validResults = results.filter(result => result.status === 'fulfilled');
     for (const result of validResults) {
-      const fulfilResult = result as PromiseFulfilledResult<PubkeysSearchResult>;
-      if (fulfilResult.value.pubkeys.length) {
-        return fulfilResult.value;
+      if (result.value.pubkeys.length) {
+        return result.value;
       }
     }
     if (results[1].status === 'rejected') {

extension/js/common/browser/browser.ts

@@ -1,8 +1,5 @@
 /* ©️ 2016 - present FlowCrypt a.s. Limitations apply. Contact [email protected] */
 
-// eslint-disable-next-line @typescript-eslint/triple-slash-reference
-/// <reference path="../../../../node_modules/@types/chrome/index.d.ts" />
-
 'use strict';
 
 import { Attachment } from '../core/attachment.js';

extension/js/common/browser/env.ts

@@ -1,8 +1,5 @@
 /* ©️ 2016 - present FlowCrypt a.s. Limitations apply. Contact [email protected] */
 
-// eslint-disable-next-line @typescript-eslint/triple-slash-reference
-/// <reference path="../../../../node_modules/@types/chrome/index.d.ts" />
-
 'use strict';
 
 import { Url } from '../core/common.js';

extension/js/common/core/crypto/pgp/openpgp-key.ts

@@ -125,7 +125,7 @@ export class OpenPGPKey {
   public static async decryptMessage(message: OpenPGP.Message<OpenPGP.Data>, privateKeys: Key[], passwords?: string[]) {
     const opgpKeys = await Promise.all(privateKeys.map(key => OpenPGPKey.extractExternalLibraryObjFromKey(key)));
     return await message.decrypt(
-      opgpKeys.filter(key => key.isPrivate()).map(key => key as OpenPGP.PrivateKey),
+      opgpKeys.filter(key => key.isPrivate()),
       passwords
     );
   }

flowcrypt-browser.code-workspace

@@ -18,8 +18,6 @@
       "**/node_modules/**": true
     },
     "errorLens.enabledDiagnosticLevels": ["error"],
-    "errorLens.errorColor": "#FF00000A",
-    "errorLens.errorTextColor": "#FF000066",
     "editor.tabSize": 2,
     "editor.codeActionsOnSave": {
       "source.fixAll.eslint": "explicit",