Minor tweaks, add release notes

Author: cowtowncoder

jr-objects/src/main/java/com/fasterxml/jackson/jr/ob/impl/BeanConstructors.java

@@ -13,6 +13,8 @@ public class BeanConstructors
     protected final Class<?> _valueType;
 
     protected Constructor<?> _noArgsCtor;
+
+    // @since 2.18
     protected Constructor<?> _recordCtor;
 
     protected Constructor<?> _intCtor;
@@ -28,6 +30,7 @@ public BeanConstructors addNoArgsConstructor(Constructor<?> ctor) {
         return this;
     }
 
+    // @since 2.18
     public BeanConstructors addRecordConstructor(Constructor<?> ctor) {
         _recordCtor = ctor;
         return this;
@@ -73,7 +76,8 @@ protected Object create() throws Exception {
         return _noArgsCtor.newInstance((Object[]) null);
     }
 
-    protected Object create(Object[] components) throws Exception {
+    // @since 2.18
+    protected Object createRecord(Object[] components) throws Exception {
         if (_recordCtor == null) {
             throw new IllegalStateException("Class "+_valueType.getName()+" does not have record constructor to use");
         }

jr-objects/src/main/java/com/fasterxml/jackson/jr/ob/impl/BeanReader.java

@@ -36,7 +36,7 @@ public class BeanReader
      */
     protected final BeanConstructors _constructors;
 
-    protected boolean _isRecordType;
+    protected final boolean _isRecordType;
 
     /**
      * Constructors used for deserialization use case
@@ -158,6 +158,7 @@ public Object read(JSONReader r, JsonParser p) throws IOException
                 return _constructors.create(p.getLongValue());
             case START_OBJECT:
                 {
+                    // [jackson-jr#148] Record deser support (2.18)
                     if (_isRecordType) {
                         final List<Object> values = new ArrayList<>();
 
@@ -170,8 +171,9 @@ public Object read(JSONReader r, JsonParser p) throws IOException
                             }
                             values.add(prop.getReader().readNext(r, p));
                         }
-                        return _constructors.create(values.toArray());
+                        return _constructors.createRecord(values.toArray());
                     }
+                    // If not Record, need to use default (no-args) Constructors
                     Object bean = _constructors.create();
                     String propName;
                     final Object[] valueBuf = r._setterBuffer;

jr-objects/src/main/java/com/fasterxml/jackson/jr/ob/impl/RecordsHelpers.java

@@ -8,7 +8,10 @@
 import java.util.Map;
 
 /**
- * Helper class to get Java Record metadata.
+ * Helper class to get Java Record metadata, from Java 8 (not using
+ * JDK 17 methods)
+ *
+ * @since 2.18
  */
 public final class RecordsHelpers {
     private static boolean supportsRecords;

jr-objects/src/main/java/com/fasterxml/jackson/jr/ob/impl/ValueReaderLocator.java

@@ -452,7 +452,6 @@ protected BeanReader _resolveBeanForDeser(Class<?> raw, POJODefinition beanDef)
         final Map<String, BeanPropertyReader> propMap;
         Map<String, String> aliasMapping = null;
 
-        boolean isRecord = RecordsHelpers.isRecordType(raw);
         if (len == 0) {
             propMap = Collections.emptyMap();
         } else {
@@ -474,12 +473,12 @@ protected BeanReader _resolveBeanForDeser(Class<?> raw, POJODefinition beanDef)
                         setter = null;
                     }
                 }
-                if (isRecord) {
+                if (RecordsHelpers.isRecordType(raw)) {
                     try {
                         field = raw.getDeclaredField(rawProp.name);
                     } catch (NoSuchFieldException e) {
-                        throw new IllegalStateException("Cannot access field " + rawProp.name
-                                + " of record class " + raw.getName(), e);
+                        throw new IllegalStateException("Cannot access field '" + rawProp.name
+                                + "' of record class `" + raw.getName() + "`", e);
                     }
                 } else {
                     // if no setter, field would do as well

release-notes/CREDITS-2.x

@@ -65,3 +65,7 @@ Julian Honnen (@jhonnen)
   when using `JSON.treeFrom()`
  (2.17.1)
 
+Tomasz Gawęda (@TomaszGaweda)
+
+* Contributed #148: Add support for Java Record deserialization
+ (2.18.0)

release-notes/VERSION-2.x

@@ -13,7 +13,8 @@ Modules:
 
 2.18.0 (not yet released)
 
-No changes since 2.17
+#148: Add support for Java Record deserialization
+ (contributed by Tomasz G)
 
 2.17.1 (04-May-2024)