Skip to content

TargetSelf attribute in Conditional element used in Attack function inside MeleeWeapon function does not work AT ALL #16072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
Regalis11 opened this issue May 14, 2025 · 0 comments
Assignees
Labels
Bug Something isn't working Code Programming task Modding Modding-related feature request or issue, or a bug that only occurs with mods Ticket The issue has been converted into an issue report.

Comments

@Regalis11
Copy link
Collaborator

Discussed in #16050

Originally posted by GluonTheDerg May 10, 2025

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

While it's clearly stated in official modding guide that TargetSelf attribute considers only characters, there not a single word about MeleeWeapon or SkillRequirement restriction
image
Still, even with TargetSelf attribute, with or without StatusEffect being used, Conditional still checks the victim, not the attacker, when using the Attack inside MeleeWeapon function.
You see, I wanted to make strict skill requirement, not RNG based luck influenced by skill stats with these StatusEffect types like "OnSuccess" and "OnFailure", as they are "The closer you are to the requirement, the higher the chance of success" type of deal, which I don't want and there's no attributes to make strict skill requirement.
The official modding guide is REALLY raw in some parts, when you, for example, want to know what kind of attributes Sound function supports, all you see when entering the page is: "Required by the core package: yes" and thats it, screw you, search and datamine inside game files on your own to find out "How" and "What".

Reproduction steps

  1. Write a MeleeWeapon function something like this:
    image
    (You can put Conditional inside or outside of StatusEffect as it doesn't work as intended in both cases).
  2. Get inside the game, start session and get the weapon.
  3. Attempt to attack some character while underskilled, condition doesn't trigger and you would think it's okay.
  4. Get yourself sufficient skill for condition to trigger, after attacking, nothing changed from previous step.
  5. Give your victim sufficient skill to trigger condition and attack the victim.
  6. Observe the absurd and ignorant logic of XML coding, as condition successfully triggers upon hitting victim, even and despite when you are underskilled, but the victim has enough of that skill

Bug prevalence

Happens every time I play

Single player or multiplayer?

Happens in both single player and multiplayer

-

No response

Version

v1.8.8.1 (Calm Before the Storm Hotfix 2)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

@Regalis11 Regalis11 self-assigned this May 14, 2025
@Regalis11 Regalis11 added Bug Something isn't working Code Programming task Modding Modding-related feature request or issue, or a bug that only occurs with mods Ticket The issue has been converted into an issue report. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task Modding Modding-related feature request or issue, or a bug that only occurs with mods Ticket The issue has been converted into an issue report.
Projects
None yet
Development

No branches or pull requests

1 participant