Fix to the env var escaping (#566)

Andrew Suderman · web-flow · commit a163b28e5389 · 2022-04-08T14:43:50.000-06:00
diff --git a/pkg/course/course.go b/pkg/course/course.go
@@ -628,7 +628,7 @@ func parseSecrets(courseData []byte) error {
 func parseEnv(data string) (string, error) {
 	dataWithEnv := os.Expand(data, func(key string) string {
 		if key == "$" {
-			return "$$"
+			return "$"
 		}
 		if value, ok := os.LookupEnv(key); ok {
 			return value
diff --git a/pkg/course/course_test.go b/pkg/course/course_test.go
@@ -249,7 +249,7 @@ func Test_parseEnv(t *testing.T) {
 		{
 			name: "escaping test",
 			data: "$$TEST_ENV_KEY",
-			want: "$$TEST_ENV_KEY",
+			want: "$TEST_ENV_KEY",
 			envMap: map[string]string{
 				"TEST_ENV_KEY": "test-env-value",
 			},

Original file line number	Diff line number	Diff line change
`@@ -628,7 +628,7 @@ func parseSecrets(courseData []byte) error {`
`628`	`628`	`func parseEnv(data string) (string, error) {`
`629`	`629`	`dataWithEnv := os.Expand(data, func(key string) string {`
`630`	`630`	`if key == "$" {`
`631`		`- return "$$"`
	`631`	`+ return "$"`
`632`	`632`	`}`
`633`	`633`	`if value, ok := os.LookupEnv(key); ok {`
`634`	`634`	`return value`
Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ func Test_parseEnv(t *testing.T) {`
`249`	`249`	`{`
`250`	`250`	`name: "escaping test",`
`251`	`251`	`data: "$$TEST_ENV_KEY",`
`252`		`- want: "$$TEST_ENV_KEY",`
	`252`	`+ want: "$TEST_ENV_KEY",`
`253`	`253`	`envMap: map[string]string{`
`254`	`254`	`"TEST_ENV_KEY": "test-env-value",`
`255`	`255`	`},`