rename pdbMinAvailableGreaterThanHPAMinReplicas to pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas

YuMuuu · YuMuuu · commit 563705160b69 · 2024-10-03T20:44:15.000+09:00
diff --git a/docs/checks/reliability.md b/docs/checks/reliability.md
@@ -21,7 +21,7 @@ key | default | description
 `topologySpreadConstraint` | `warning` | Fails when there is no topology spread constraint on the pod
 `hpaMaxAvailability` | `warning` | Fails when `maxAvailable` lesser or equal than `minAvailable` (if defined) for a HorizontalPodAutoscaler
 `hpaMinAvailability` | `warning` | Fails when `minAvailable` (if defined) lesser or equal to one for a HorizontalPodAutoscaler
-`pdbMinAvailableGreaterThanHPAMinReplicas` | `warning` |  Fails when PDB `minAvailable` is greater than HPA `minReplicas`
+`pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas` | `warning` |  Fails when PDB `minAvailable` is greater than or equal to HPA `minReplicas`
 
 ## Background
 
diff --git a/pkg/config/checks.go b/pkg/config/checks.go
@@ -69,7 +69,7 @@ var (
 		"rolebindingClusterAdminRole",
 		"hpaMaxAvailability",
 		"hpaMinAvailability",
-		"pdbMinAvailableGreaterThanHPAMinReplicas",
+		"pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas",
 	}
 
 	// BuiltInChecks contains the checks that come pre-installed w/ Polaris
diff --git a/pkg/config/default.yaml b/pkg/config/default.yaml
@@ -12,7 +12,7 @@ checks:
   topologySpreadConstraint: warning
   hpaMaxAvailability: warning
   hpaMinAvailability: warning
-  pdbMinAvailableGreaterThanHPAMinReplicas: warning
+  pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas: warning
 
   # efficiency
   cpuRequestsMissing: warning
diff --git a/pkg/config/examples/config-full.yaml b/pkg/config/examples/config-full.yaml
@@ -12,7 +12,7 @@ checks:
   metadataAndInstanceMismatched: warning
   hpaMaxAvailability: warning
   hpaMinAvailability: warning
-  pdbMinAvailableGreaterThanHPAMinReplicas: warning
+  pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas: warning
 
   # efficiency
   cpuRequestsMissing: warning
diff --git a/pkg/validator/pdb_hpa_validator.go b/pkg/validator/pdb_hpa_validator.go
@@ -16,10 +16,10 @@ import (
 )
 
 func init() {
-	registerCustomChecks("pdbMinAvailableGreaterThanHPAMinReplicas", pdbMinAvailableGreaterThanHPAMinReplicas)
+	registerCustomChecks("pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas", pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas)
 }
 
-func pdbMinAvailableGreaterThanHPAMinReplicas(test schemaTestCase) (bool, []jsonschema.ValError, error) {
+func pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas(test schemaTestCase) (bool, []jsonschema.ValError, error) {
 	if test.ResourceProvider == nil {
 		return true, nil, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ var (`
`69`	`69`	`"rolebindingClusterAdminRole",`
`70`	`70`	`"hpaMaxAvailability",`
`71`	`71`	`"hpaMinAvailability",`
`72`		`- "pdbMinAvailableGreaterThanHPAMinReplicas",`
	`72`	`+ "pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas",`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`// BuiltInChecks contains the checks that come pre-installed w/ Polaris`
Original file line number	Diff line number	Diff line change
`@@ -16,10 +16,10 @@ import (`
`16`	`16`	`)`
`17`	`17`
`18`	`18`	`func init() {`
`19`		`- registerCustomChecks("pdbMinAvailableGreaterThanHPAMinReplicas", pdbMinAvailableGreaterThanHPAMinReplicas)`
	`19`	`+ registerCustomChecks("pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas", pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas)`
`20`	`20`	`}`
`21`	`21`
`22`		`-func pdbMinAvailableGreaterThanHPAMinReplicas(test schemaTestCase) (bool, []jsonschema.ValError, error) {`
	`22`	`+func pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas(test schemaTestCase) (bool, []jsonschema.ValError, error) {`
`23`	`23`	`if test.ResourceProvider == nil {`
`24`	`24`	`return true, nil, nil`
`25`	`25`	`}`