Fixing BasePath for loading static assets and routing when a URL doesn't have a forward slash suffix (#713)

* Remove suffix trimming on BasePath

* Remove forward-slash prefix for static images in html templates

* Allow for routing on base URLs missing a forward-slash suffix

* Move rootURL routing functionality to new method, modify its if statement, trim suffix for router's PathPrefix, move opts to a class-wide variable, add a new Handler for rootURLs without the forward slash

* Reverted previous commit aside from trimming the suffix of the BasePath in the router builder, added StrictSlash(true) to the router builder

* Reformatted router.go

Author: HereGoesName

cmd/dashboard.go

@@ -75,5 +75,9 @@ func validateBasePath(path string) string {
 		path = "/" + path
 	}
 
-	return strings.TrimSuffix(path, "/")
+	if !strings.HasSuffix(path, "/") {
+		path = path + "/"
+	}
+
+	return path
 }

pkg/dashboard/router.go

@@ -17,6 +17,7 @@ package dashboard
 import (
 	"net/http"
 	"path"
+	"strings"
 
 	"k8s.io/klog/v2"
 
@@ -50,7 +51,7 @@ func GetRouter(setters ...Option) *mux.Router {
 		setter(opts)
 	}
 
-	router := mux.NewRouter().PathPrefix(opts.BasePath).Subrouter()
+	router := mux.NewRouter().PathPrefix(strings.TrimSuffix(opts.BasePath, "/")).Subrouter().StrictSlash(true)
 
 	// health
 	router.Handle("/health", Health("OK"))

pkg/dashboard/templates/cost_settings.gohtml

@@ -13,15 +13,15 @@
           <div class="cost-settings-box__select-container">
             <select name="cloud-providers" id="cost-settings-box__cloud-providers">
             </select>
-            <img src="/static/images/triangle.svg" alt="Select Icon" aria-hidden="true" />
+            <img src="static/images/triangle.svg" alt="Select Icon" aria-hidden="true" />
           </div>
         </div>
         <div class="cost-settings-box__instance-types">
           <label for="cost-settings-box__instance-types">Instance Type</label>
           <div class="cost-settings-box__select-container">
             <select name="instance-types" id="cost-settings-box__instance-types">
             </select> 
-            <img src="/static/images/triangle.svg" alt="Select Icon" aria-hidden="true" />
+            <img src="static/images/triangle.svg" alt="Select Icon" aria-hidden="true" />
           </div>
         </div>
       </div>

pkg/dashboard/templates/footer.gohtml

@@ -5,21 +5,21 @@
   </div>
   <div class="footer__middle">
    <a href="https://github.com/FairwindsOps">
-     <img src="/static/images/github.svg" alt="Github" />
+     <img src="static/images/github.svg" alt="Github" />
    </a>
    <a href="https://twitter.com/fairwindsops">
-     <img src="/static/images/twitter.svg" alt="Twitter" />
+     <img src="static/images/twitter.svg" alt="Twitter" />
    </a>
    <a href="https://join.slack.com/t/fairwindscommunity/shared_invite/zt-e3c6vj4l-3lIH6dvKqzWII5fSSFDi1g">
-     <img src="/static/images/slack.svg" alt="Slack" />
+     <img src="static/images/slack.svg" alt="Slack" />
    </a>
    <a href="https://www.fairwinds.com/fairwinds-newsletter">
-     <img src="/static/images/email.svg" alt="Email" />
+     <img src="static/images/email.svg" alt="Email" />
    </a>
   </div>
   <div class="footer__logo">
     <a href="https://fairwinds.com">
-      <img src="/static/images/fairwinds-logo.svg" alt="Fairwinds Logo" />
+      <img src="static/images/fairwinds-logo.svg" alt="Fairwinds Logo" />
     </a>
   </div>
   <div class="footer__bottom">