Skip to content

Incomplete Support for Unicast Hellos #18552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmw12306 opened this issue Apr 1, 2025 · 1 comment
Open

Incomplete Support for Unicast Hellos #18552

zmw12306 opened this issue Apr 1, 2025 · 1 comment

Comments

@zmw12306
Copy link
Contributor

zmw12306 commented Apr 1, 2025

Incomplete Support for Unicast Hellos (RFC 8966 Appendix F Non-Compliance)

It seems the current implementation doesn't support unicast at this moment. In the future, it would be important to support:

  1. Missing Unicast Hello Sequence Number Tracking
    Problem: The implementation only tracks a single Hello sequence number per neighbor.
    RFC Requirement: Separate sequence numbers must be maintained for unicast and multicast Hellos.
    Suggested Fix:
    Add unicast_hello_seqno_in and unicast_hello_seqno_out fields to the struct neighbor.

  2. Incomplete Hello History Tracking
    Problem: A single reach field is used to track Hello history.
    RFC Requirement: Hello histories must be tracked independently for multicast and unicast Hellos.
    Suggested Fix:
    Add separate mcast_reach and ucast_reach fields in the neighbor structure.

  3. Incomplete Timer Handling
    Problem: There is no separate timer for unicast Hellos.
    RFC Requirement: Timer logic must independently handle expiration for each Hello type.
    Suggested Fix:
    Add a ucast_hello_time field and update the Hello timer processing logic accordingly.

@riw777
Copy link
Member

riw777 commented Apr 1, 2025

Are you going to push a commit to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants