fix(Pointers): ensure visible renderers list is cleared correctly

thestonefox · thestonefox · commit 2ede03ff0afd · 2017-10-24T16:28:42.000+01:00
The `makeRendererVisible` list was being cleared during a loop within
the loop so it wasn't being cleared correctly.

The better approach is to simply clear the entire list after the loop
is done.
diff --git a/Assets/VRTK/Scripts/Pointers/PointerRenderers/VRTK_BasePointerRenderer.cs b/Assets/VRTK/Scripts/Pointers/PointerRenderers/VRTK_BasePointerRenderer.cs
@@ -411,8 +411,8 @@ protected virtual void MakeRenderersVisible()
             for (int i = 0; i < makeRendererVisible.Count; i++)
             {
                 ToggleRendererVisibility(makeRendererVisible[i], true);
-                makeRendererVisible.Remove(makeRendererVisible[i]);
             }
+            makeRendererVisible.Clear();
         }
 
         protected virtual void ToggleRendererVisibility(GameObject givenObject, bool state)

Original file line number	Diff line number	Diff line change
`@@ -411,8 +411,8 @@ protected virtual void MakeRenderersVisible()`
`411`	`411`	`for (int i = 0; i < makeRendererVisible.Count; i++)`
`412`	`412`	`{`
`413`	`413`	`ToggleRendererVisibility(makeRendererVisible[i], true);`
`414`		`- makeRendererVisible.Remove(makeRendererVisible[i]);`
`415`	`414`	`}`
	`415`	`+ makeRendererVisible.Clear();`
`416`	`416`	`}`
`417`	`417`
`418`	`418`	`protected virtual void ToggleRendererVisibility(GameObject givenObject, bool state)`