Skip to content

The "unread" dot in the Chrome tab icon is so small as to be almost invisible #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvtglobally opened this issue Jul 11, 2022 · 13 comments
Closed
Assignees
Labels
Design Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open app and login in browser
  2. From another account send couple messages
  3. Check the "unread" indicator in the tab

Expected Result:

User should be able to see that there are unread messages

Actual Result:

User can see unread message indicator, but the The "unread" dot in the Chrome tab icon is so small as to be almost invisible

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.82-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1657511930574589

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@robertjchen
Copy link
Contributor

Yep, definitely not ideal! Wanted to loop in @Expensify/design on this: could we possibly get a mockup of what a new "unread" indicator would look like? It sounds like we might be changing it to a green color in addition to making it larger?

@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@shawnborton
Copy link
Contributor

Yup and perhaps we want to add some logic here:

  • green is the default for unreads, etc
  • show red when there is an error

Though I'm not sure if we have any red brick road logic just yet...

@robertjchen robertjchen added the Improvement Item broken or needs improvement. label Jul 11, 2022
@shawnborton
Copy link
Contributor

Posted an idea here

image

@robertjchen
Copy link
Contributor

Looks great! We just need to swap out https://github.com/Expensify/App/blob/main/web/favicon-unread.png and we should be good to go here.

@parasharrajat
Copy link
Member

Won't be that simple if we are looking to add two different ones based on error or non-error state.

@robertjchen
Copy link
Contributor

Agreed- maybe we can just narrowly-scope this for just the unreads first. The error state would require some planning and discussion, especially since how the way we surface errors may be changing.

@shawnborton
Copy link
Contributor

Let me know if these images work: Notification Dot.zip

@robertjchen
Copy link
Contributor

It's beautiful, thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2022
@robertjchen
Copy link
Contributor

Need to test things out before opening it up for review.

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2022
@robertjchen
Copy link
Contributor

Update before going OOO: working through the test/screenshots checklist in the PR.

@melvin-bot melvin-bot bot added the Overdue label Aug 22, 2022
@shawnborton
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 22, 2022
@robertjchen robertjchen added the Reviewing Has a PR in review label Aug 23, 2022
@melvin-bot melvin-bot bot closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants