[$250] iOS/Android - Workspace - Keypad overlaps "Call me" button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app and login
2. Tap profile and select workspace
3. Tap "?" and tap "Request a set up call"
4. Tap phone number field and observe

Expected Result:

Opened keypad should not overlap the "Call me" button

Actual Result:

Keypad overlaps "Call me" button

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.82.5

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alex-mechler]

Display issue, looks like a perfect external issue!

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

internal
external

[parasharrajat]

Maybe a regression from #9665.

[WtfLaika]

Have you tried to use KeyboardAvoidingView? Wrap all components with KeyboardAvoidingView set behavior='position' and make small padding bottom or set value for keyboardVerticalOffset.

[parasharrajat]

@adelekennedy It is missing Exported label.

[WtfLaika]

Must be something like this

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mananjadhav]

I haven't been able to reproduce this on my iOS v1.1.78-8.

call-me-button-position_DJYClIFB.mp4

but can on v1.1.82-5

As @parasharrajat pointed out it looks like a regression.

[mountiny]

@kbecciv Can you please confirm if you can repro this in production as well as staging? That would help us narrow down the problem.

[kbecciv]

@mountiny I checked production version and issue is not there. Let's add Deploy blocker to this issue.

Here is potential PR #9573

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@kbecciv Thanks for the confirmation, very helpful 🙌

Having a look now!

[mountiny]

@kbecciv Could you actually confirm with a video share this really is not reproducible on production? The screenshot is not clear to me.

The reason I am asking is that it seems that this PR is the main suspect for causing it, however, it is already in production. I could not find anything in Staging which might be causing this.

[mountiny]

K, this was a bit of pain to investigate.

### What happened

@ctkochan22 has introduced refactor of the FormAlertWithSubmitButton component in this PR. Those changes are fine on their own, however, then @yuwenmemon has started to use this component at the RequestCallPage in this PR which got merged right when the Form refactor happened so Yuwen could not really well know about those changes.

Additionally, given both of those PRs are already in production, it was probably this change of the styles, which seemingly should not have an effect on this behaviour, but it evidently did, but honestly i dont know right now why.

I am still not 100% sure how come it is fine in production and broken in staging, however, the PR I put up is fixing this problem by resetting the flex property on the form submit button on the RequestCallPage :)

[mountiny]

Not External anymore, @adelekennedy would you be able to please delete the job from upwork for this one. Thank you very much!

[kbecciv]

@mountiny Please attached video from production per your request.

Image.from.iOS.40.MP4

[b1tjoy]

Additionally, given both of those PRs are already in production, it was probably this change of the styles, which seemingly should not have an effect on this behaviour, but it evidently did, but honestly i dont know right now why.

@mountiny PR #9865 does not cause this behavior. FixedFooter is a View with style of flexShrink: 0, and the inner FormAlertWrapper is a View with style of flex: 1, the combination cause this issue, and reset the inner component style to flex: undefined will fix it, as the PR you just submitted :)

[ctkochan22]

Great find @mountiny

[mountiny]

@ctkochan22 Cheers 🙏

@kbecciv Thank you very much 🙌

@b1tjoy Thanks for follow up, I agree it is not the PR itself, but I am not sure why is this fine in production? Looking at the production code, the RequestCallPage and FormAlertWrapper look basically same (just different way of passing the styles, but I feel like that should not be a problem). The FixedFooter styles are same too.

[ctkochan22]

Tested on staging ios, we are good