Skip to content

[HOLD - App Navigation Reboot] [$500] mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan & @Puneet-here #9253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kbecciv opened this issue May 31, 2022 · 91 comments
Closed

[HOLD - App Navigation Reboot] [$500] mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan & @Puneet-here #9253

kbecciv opened this issue May 31, 2022 · 91 comments
Assignees
@AndrewGable @ntdiary @strepanier03
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented May 31, 2022 •
edited by mvtglobally
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open the chat area.
  3. Click on any chat, then navigate back to chat area.
  4. Click on different chat this time and navigate back and look at top where username is displayed.
  5. If everything is working fine then repeat steps 2 and 3 again.

Expected Result:

Previous chat username is not displayed when you navigate back from different chat

Actual Result:

Previous chat username is displayed when you navigate back from different chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web (Android and Safari)

Version Number: 1.1.69.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2022-05-03-18-10-36_9ywUg6Hk.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ Yash Chauhan @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1651639523326759

View all open jobs on GitHub
@kbecciv kbecciv added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 31, 2022
@kbecciv kbecciv added AutoAssignerTriage Auto assign issues for triage to an available triage team member and removed Daily KSv2 labels May 31, 2022
@melvin-bot melvin-bot bot added the Daily KSv2 label May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Current assignee @CortneyOfstad is eligible for the AutoAssignerTriage assigner, not assigning anyone new.

@kbecciv kbecciv removed the Daily KSv2 label May 31, 2022
@Puneet-here
Copy link
Contributor

It was already reported by me here

@CortneyOfstad CortneyOfstad removed their assignment May 31, 2022
@CortneyOfstad CortneyOfstad added Engineering and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@TomatoToaster TomatoToaster changed the title mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan & @Puneet-here Jun 2, 2022
@TomatoToaster TomatoToaster added Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Jun 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2022

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@TomatoToaster TomatoToaster removed their assignment Jun 2, 2022
@TomatoToaster
Copy link
Contributor

@bfitzexpensify, just noting that that there were two people who reported this bug and the GH body and title were changed to reflect this.

@bfitzexpensify

This comment was marked as outdated.

Sign in to view
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 3, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 10, 2022

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 10, 2022
@adelekennedy
Copy link

@strepanier03 reassigning to you while I'm ooo next week

@strepanier03
Copy link
Contributor

Taking this over for @adelekennedy but I'm not sure what the status is or what is meant to be doing. @adelekennedy next time you reassign a GH it might be a good idea to leave a couple sentence update for the person taking it over.

Doesn't appear there is anything actionable on my end for today so I'll dig into this on Monday and get caught up on the discussion for why this is on hold.

@strepanier03
Copy link
Contributor

Okay, based on what I've read and understand, the GH for getting in control of navigation is holding this GH for the time being.

The last comment on the GH says a DD will be coming soon. I'll follow along.

@strepanier03
Copy link
Contributor

Design Doc for App Navigation reboot is out.

Moving this to weekly for the time being.

@strepanier03 strepanier03 added Weekly KSv2 and removed Daily KSv2 labels Nov 18, 2022
@strepanier03
Copy link
Contributor

I am out of the office Wednesday-Sunday and will return Monday. If urgent help is needed for this GH please post your request and the URL in #expensify-open-source.

@strepanier03
Copy link
Contributor

Design Doc reviews are looking great, will continue following project's progress on this.

@strepanier03
Copy link
Contributor

I am OoO for jury duty tomorrow. If immediate action is needed on this GH please post in #expensify-open-source for another BZ's assistance, thank you.

@strepanier03
Copy link
Contributor

Detailed DD is about a week out. Most recent update here.

@strepanier03
Copy link
Contributor

Still moving forward - update.

@strepanier03
Copy link
Contributor

Moving to Monthly for now while I'm ooo and will put back to Weekly when I return. I do not expect this to need action while I'm away.

@strepanier03 strepanier03 added Monthly KSv2 and removed Weekly KSv2 labels Dec 16, 2022
@strepanier03
Copy link
Contributor

Head's up

I am out of the office starting December 17th and will return on January 3rd. During this time, if this GH needs action from a BugZero team member, please post in #expensify-open-source with a link to the GH to ask for some help.

Cheers! ☃️

@mananjadhav mananjadhav removed their assignment Dec 17, 2022
@trjExpensify trjExpensify changed the title [HOLD] [$500] mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan & @Puneet-here [HOLD - App Navigation Reboot] [$500] mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan & @Puneet-here Dec 20, 2022
@strepanier03 strepanier03 added Weekly KSv2 and removed Monthly KSv2 labels Jan 13, 2023
@strepanier03
Copy link
Contributor

Most recent update here. Will continue to follow along with the progress.

@strepanier03
Copy link
Contributor

Still on hold, but due to the most recent update here we are going to step back and take our time building our own library.

I'm going to move this GH to Monthly until there is an update.

@strepanier03 strepanier03 added Monthly KSv2 and removed Weekly KSv2 labels Jan 20, 2023
@melvin-bot melvin-bot bot closed this as completed Mar 20, 2023
@MelvinBot
Copy link

@AndrewGable, @ntdiary, @strepanier03, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@ntdiary ntdiary mentioned this issue Mar 28, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewGable AndrewGable

@ntdiary ntdiary

@strepanier03 strepanier03

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests