Skip to content

[HOLD for payment 2022-07-15] [$250] Password Field should not Autofill with the old password on the Set Password page - reported by @parasharrajat #9244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvtglobally opened this issue May 31, 2022 · 47 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go the login page.
  2. Enter an email. Press Enter.
  3. Click forget on the password page.
  4. Check the mailbox and Copy the link.
  5. open the link on the browser

Expected Result:

Check that if you had saved the password earlier for the email, password field is autofilled.

Actual Result:

It should not autofill with old password as user is expected to enter new password.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-05-31T002838 657

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1651158076558069

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @trjExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 31, 2022
@trjExpensify trjExpensify removed their assignment May 31, 2022
@trjExpensify trjExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 31, 2022
@trjExpensify
Copy link
Contributor

I'm OOO this week, reassigning.

@conorpendergrast
Copy link
Contributor

It looks like there's this autocomplete="new-password" we could add to the password field when they're setting a new password. Seems like that would be helpful!

@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2022

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alex-mechler
Copy link
Contributor

Looks good to handle externally!

@alex-mechler alex-mechler removed their assignment Jun 1, 2022
@alex-mechler alex-mechler added the External Added to denote the issue can be worked on by a contributor label Jun 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2022

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@adelekennedy
Copy link

internal
external

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 6, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 27, 2022
@Julesssss
Copy link
Contributor

Hi @Harshdeepjoshi, any progress to report?

@melvin-bot melvin-bot bot removed the Overdue label Jun 27, 2022
@Julesssss
Copy link
Contributor

Whoops, I see the PR now

@Julesssss
Copy link
Contributor

Nice work on your first PR @Harshdeepjoshi! It has been merged, we now need to wait for it to be deployed. 7 days after that you should be paid

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2022
@adelekennedy
Copy link

not overdue - waiting for it to be deployed

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Weekly KSv2 labels Jul 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.79-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-07-15. 🎊

@melvin-bot melvin-bot bot changed the title [$250] Password Field should not Autofill with the old password on the Set Password page - reported by @parasharrajat [HOLD for payment 2022-07-15] [$250] Password Field should not Autofill with the old password on the Set Password page - reported by @parasharrajat Jul 8, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 14, 2022
@Julesssss
Copy link
Contributor

Can be paid today

@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2022
@adelekennedy
Copy link

Paid! @parasharrajat I missed hiring you for the reporting bonus, will you apply here

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2022
@parasharrajat
Copy link
Member

@adelekennedy Please check I have already applied.

@melvin-bot melvin-bot bot added the Overdue label Jul 20, 2022
@adelekennedy
Copy link

hired!

@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2022
@parasharrajat
Copy link
Member

Thanks, there is also reporting bonus for this one 😃

@adelekennedy
Copy link

@parasharrajat to confirm are you eligible for more than the reporting bonus? I see that @rushatgabhane was assigned as the C+ and @Harshdeepjoshi was assigned as the contributor, am I missing something? Please let me know 😄

@parasharrajat
Copy link
Member

oh, my bad. I confused this with someone else. So just for the reporting.

@adelekennedy
Copy link

Perfect - and no worries, you're juggling a ton of issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

10 participants