Web - "Expense Violations" tab enabled is not showing any confirmation and after refresh, disable

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Access staging.expensify.com
Sign into a verified account
Go to the Policy and to the "Expenses" tab
Click on the "Enable" button next to "Expense Violations"
Refresh the page

Expected Result:

The user expects to see a confirmation message that the Violations have actually been enabled or a message to refresh the page to renew the policy

Actual Result:

The user does not receive any message confirmation and after refreshing the page, the "Expense Violations" tab is disabled again

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: n/a

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

163877773-b1c1face-fb1c-4822-b074-fac5a61f50d7.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

Joel already triaged in https://github.com/Expensify/Expensify/issues/207142

[laurenreidexpensify]

@joelbettner's comment from there -
Oh...actually, I just tested this myself. The reason enabling expense violations on a policy isn't "sticking" is because there were no parameters added for what constitutes a violation. Thus, since there was nothing to enforce, we show the violations as turned off after the refresh. As soon as I put something in to enforce for expense violations, the violations stayed on.

So...now I'm not so sure if this is a bug, or a feature. @laurenreidexpensify your thoughts here on whether or not this needs to be fixed? It certainly isn't a rush and could be worked on externally. (un-assigning myself)

[laurenreidexpensify]

@AndrewGable second pair of eyes pls - given Joel's comments above? Thanks!

[AndrewGable]

1. This looks like it will be an internal issue as it's OldDot
2. Yes, I do think that there needs to be a value inputted for it to "stick"

[laurenreidexpensify]

oh my god yesterday was not my day 🤦🏽‍♀️ 🤦🏽‍♀️ it threw me that someone from Applause had created this E/E ! Will re-open the original issue