Skip to content

[$1000] Visiting room by pasting URL, doesn't read messages - reported by @K4tsuki #7837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvtglobally opened this issue Feb 20, 2022 · 32 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Close all Expensify browser tabs.
  2. Send a message to a room using other device
  3. Visit the room directly by url (for example new.expensify.com/r/XXXXXX ) or by home url if the room is last visited.
  4. Verify that room style keep displayed as unread and unread line indicator (green line) keep being shown even after user scroll up and down in the message. Even after user navigate to other room, room style keep displayed as unread.

Expected Result:

Room style must be displayed as read (not in bold) and unread indicator line will disappear after user scroll chat up and down.

Actual Result:

Room style keep displayed as unread and unread line indicator (green line) keep being shown even after user scroll up and down in the message. Even after user navigate to other room, room style keep displayed as unread.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

marker.mp4

Expensify/Expensify Issue URL:
Issue reported by: @K4tsuki
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644253704477339

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Feb 20, 2022
@MelvinBot
Copy link

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Feb 20, 2022
@flaviadefaria
Copy link
Contributor

Makes sense to fix this. I also tested in Slack and after a few seconds in the room, the conversation is "marked as read" and the room name is no longer flagged in bold.

@MelvinBot
Copy link

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flaviadefaria flaviadefaria removed their assignment Feb 21, 2022
@joelbettner
Copy link
Contributor

Yeah, this should definitely be fixed. Un-assigning myself and labeling as external.

@joelbettner joelbettner added the External Added to denote the issue can be worked on by a contributor label Feb 21, 2022
@MelvinBot
Copy link

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mateusbra
Copy link
Contributor

maybe duplicate of #6471

@MelvinBot
Copy link

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@K4tsuki
Copy link
Contributor

K4tsuki commented Feb 25, 2022

Is this duplicate issue? Could I submit a proposal?

@MelvinBot
Copy link

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@MelvinBot
Copy link

10 days overdue. Is anyone even seeing these? Hello?

@MelvinBot MelvinBot added Weekly KSv2 and removed Daily KSv2 labels Mar 9, 2022
@MelvinBot
Copy link

This issue has not been updated in over 14 days. eroding to Weekly issue.

@MelvinBot MelvinBot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 18, 2022
@MelvinBot

This comment was marked as off-topic.

@mallenexpensify mallenexpensify added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 18, 2022
@mallenexpensify
Copy link
Contributor

Sorry for the spammin'
The CM originally got removed by mistake so I'm hopping in (then... somehow removed folks, I'm blaming GH)
@parasharrajat , can you check #6471 to see if it's related to this?

@parasharrajat
Copy link
Member

It does not look related. But we can ask QA to retest it when #6471 is on staging.

@mallenexpensify mallenexpensify changed the title Visiting room by pasting URL, doesn't read messages - reported by @K4tsuki [$500] Visiting room by pasting URL, doesn't read messages - reported by @K4tsuki Mar 28, 2022
@mallenexpensify
Copy link
Contributor

Doubled price to $500
https://www.upwork.com/jobs/~0108a6d5655ee24bf8

@pecanoro
Copy link
Contributor

pecanoro commented Apr 6, 2022

Not overdue!

@melvin-bot melvin-bot bot removed the Overdue label Apr 6, 2022
@mallenexpensify
Copy link
Contributor

Doubled price to $1000
https://www.upwork.com/jobs/~0108a6d5655ee24bf8

@mallenexpensify mallenexpensify changed the title [$500] Visiting room by pasting URL, doesn't read messages - reported by @K4tsuki [$1000] Visiting room by pasting URL, doesn't read messages - reported by @K4tsuki Apr 13, 2022
@mateusbra
Copy link
Contributor

mateusbra commented Apr 13, 2022

After #6471 was deployed to staging I was unable to reproduce it from my side, I think we could tag some QA and see if it's still reproducible.

It does not look related. But we can ask QA to retest it when #6471 is on staging.

I think even its not being related we ended up also solving this one in #6471

Just need to confirm with some QA

@mallenexpensify
Copy link
Contributor

@isabelastisser @mvtglobally can you test to see if you're able to reproduce? Thanks!

@isabelastisser
Copy link
Contributor

Hey @mallenexpensify , did you mean to tag @isagoico? :)

@mallenexpensify
Copy link
Contributor

Indeed! Sorry @isabelastisser (I'm surprised this doesn't happen 10x as much)

@mallenexpensify
Copy link
Contributor

@isagoico and @mvtglobally , are you able to reproduce?

@isagoico

This comment was marked as resolved.

@mateusbra
Copy link
Contributor

@isagoico I think that for this issue you should open it directly by pasting the URL.
The steps would be:

  1. Open the report as user A.
  2. Copy the report URL and close the tab on browser.
  3. Send messages from user B to user A.
  4. Open the report directly by pasting the copied URL.

Is that right?

cc: @parasharrajat
cc: @mvtglobally

@isagoico
Copy link

I was unable to reproduce the same issue on my side following those steps. Please check the video and let me know if the steps are incorrect.

Recording.4.mp4

@mateusbra
Copy link
Contributor

You're right, that's the correct steps. But I think that's the expected behavior, isn't?

Expected Result:

Room style must be displayed as read (not in bold) and unread indicator line will disappear after user scroll chat up and down.

@isagoico
Copy link

Yeap, the issue is not reproducible. Behavior was the expected on my side.
I was able to reproduce a similar issue using the URL but I don't have solid reproducible steps, will keep investigating and trying to replicate again🕵️

@pecanoro
Copy link
Contributor

If no one can reproduce it, let's close it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests