Skip to content

Infinite Spinner displayed after Log out and log back in #7659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvtglobally opened this issue Feb 9, 2022 · 9 comments
Closed

Infinite Spinner displayed after Log out and log back in #7659

mvtglobally opened this issue Feb 9, 2022 · 9 comments
Assignees
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

mvtglobally commented Feb 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Updated staging to Version 1.1.38-1.
  2. Sign out > quit app > reopen.
  3. Enter username and try to login again

Expected Result:

user should be able to sign in

Actual Result:

user is unable to sign in. Infinite spinner displayed

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: 1.1.38-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen Shot 2022-02-09 at 2 08 42 PM
image - 2022-02-09T140910 287

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644432266869919

View all open jobs on GitHub

@mvtglobally mvtglobally added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Engineering labels Feb 9, 2022
@MelvinBot
Copy link

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@roryabraham
Copy link
Contributor

Working on this. I believe it only affects desktop, not other platforms.

@roryabraham
Copy link
Contributor

Got a PR up to fix this

@roryabraham roryabraham added the Reviewing Has a PR in review label Feb 9, 2022
@mallenexpensify
Copy link
Contributor

Thanks @roryabraham , I have not be able to reproduce on web. Let me know if you need any help testing.

@botify botify closed this as completed Feb 10, 2022
@mvtglobally
Copy link
Author

Reopening
Screen Shot 2022-02-10 at 4 07 21 PM

@mvtglobally mvtglobally reopened this Feb 10, 2022
@roryabraham
Copy link
Contributor

This should be fixed (again) by #7685

@mvtglobally
Copy link
Author

I was able to re-download app and login. So far looking good. Team is running additional validations

@roryabraham
Copy link
Contributor

Great, thanks. I'm pretty confident that this is fixed, so I'm going to close it out. Feel free to reopen if you find anything related to CORS errors or Electron wetting the bed like it did above.

@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants