-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New room - Unable to create a room with visibility as "Private" #6757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @iwiznia ( |
I'm not sure this should be a deploy blocker, given that the feature is behind a beta flag and seems to still be in development. But I am also seeing this behavior and while the room is created, it does not appear in the LHN. CC @jasperhuangg as I think it was introduced with this PR. Also CC @yuwenmemon as I think you know the feature best. Are we aware of this behavior? |
I can take a look at this one. @Julesssss The reports aren't correctly shared with users who create them and that's being resolved here: #6726 Not being able to create private seems like its own issue though with the new room modal so I'll look into it. |
I can look into the issue with the dropdown. I actually spent a while debugging this locally while implementing the PR, so I'm surprised that this is still cropping up in staging. |
Okay.... I don't know what happened here but the value for the dropdown is hardcoded to restricted. PR incoming... Github needs that :wat emoji we have on Slack. PR: #6805 |
Yo Melvin I just commented and attached a PR, this shouldn't be overdue anymore? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Able to create a Private room
Actual Result:
Unable to create a Private room, it keeps switching to "restricted"
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: v1.1.20-1
Reproducible in staging?: Yes
Reproducible in production?: New feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Android.mp4.mp4
iOS.MP4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: