Skip to content

New room - Unable to create a room with visibility as "Private" #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavimuru opened this issue Dec 14, 2021 · 7 comments
Closed

New room - Unable to create a room with visibility as "Private" #6757

kavimuru opened this issue Dec 14, 2021 · 7 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Tap on Plus button and Select New Room
  4. Enter a name for the room
  5. Select any Workspace
  6. Change Visibility to Private and tap Create Room

Expected Result:

Able to create a Private room

Actual Result:

Unable to create a Private room, it keeps switching to "restricted"

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.20-1

Reproducible in staging?: Yes

Reproducible in production?: New feature

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Android.mp4.mp4
iOS.MP4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

Julesssss commented Dec 14, 2021

I'm not sure this should be a deploy blocker, given that the feature is behind a beta flag and seems to still be in development. But I am also seeing this behavior and while the room is created, it does not appear in the LHN.

CC @jasperhuangg as I think it was introduced with this PR. Also CC @yuwenmemon as I think you know the feature best. Are we aware of this behavior?

@TomatoToaster TomatoToaster removed the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2021
@TomatoToaster TomatoToaster added Daily KSv2 and removed Hourly KSv2 labels Dec 14, 2021
@TomatoToaster
Copy link
Contributor

TomatoToaster commented Dec 14, 2021

I can take a look at this one. @Julesssss The reports aren't correctly shared with users who create them and that's being resolved here: #6726

Not being able to create private seems like its own issue though with the new room modal so I'll look into it.

@jasperhuangg
Copy link
Contributor

I can look into the issue with the dropdown. I actually spent a while debugging this locally while implementing the PR, so I'm surprised that this is still cropping up in staging.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Dec 16, 2021

Okay.... I don't know what happened here but the value for the dropdown is hardcoded to restricted. PR incoming... Github needs that :wat emoji we have on Slack.

cc @TomatoToaster

PR: #6805

@jasperhuangg
Copy link
Contributor

Yo Melvin I just commented and attached a PR, this shouldn't be overdue anymore?

@jasperhuangg jasperhuangg self-assigned this Dec 16, 2021
@TomatoToaster TomatoToaster added the Reviewing Has a PR in review label Dec 16, 2021
@MelvinBot MelvinBot removed the Overdue label Dec 16, 2021
@botify botify closed this as completed Dec 16, 2021
@TomatoToaster TomatoToaster removed their assignment Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants