Workspace settings - App's orientation does not change to Landscape

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found when executing #6648

Action Performed:

1. Launch the app
2. Go to settings
3. Tap on a workspace
4. Change the orientation to landscape

Expected Result:

App's orientation changes to landscape

Actual Result:

App's orientation remains in Portrait

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.20-0
Reproducible in staging?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Image.from.iOS.MP4

Issue was found when executing #6648

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mountiny]

Removing deploy blocker as it does not seem very urgent. However, I have teated on staging and the I cant switch to landscape at any screen.

[luacmartins]

This is intentional after this PR #6608. I think we can close this issue, unless not being able to change to landscape mode is blocking some functionality.

[mountiny]

@luacmartins thank you for a heads up! Is there an official way to update QA tests so they test for not being able to turn to landscape instead? 😅

[mountiny]

Based on the Slack thread linked in the issue by Carlos, also here, this is intentional and on phones, we should not be able to rotate to landscape anymore.

However, the rotation should be possible on tablets.

@kavimuru could you please update the testing instructions to make sure we correctly QA for this new expected behaviour? Thank you very much 🙇

[ogumen]

@mountiny from the accessibility perspective restricting the content view and operation to a single display orientation fails WCAG 2.1 SC 1.3.4

[mountiny]

@ogumen ah, thank you for raising this issue. It has been a decision made by more people so i will need to discuss with them.

[kavimuru]

@mountiny, I have edited the steps. Also it works fine in iPad though.

CTUV5023.MP4

.

[mountiny]

Thank you @kavimuru! I will bring up the accessibility issues in Slack to see what is our approach here and whether to revert this decision now knowing it breaks accessibility rules.

[mountiny]

@ogumen Brought this issue up in Slack.

[mountiny]

Discussion still going on.

[mountiny]

The teams are still discussing this coming to Christmas break.

[mountiny]

@kavimuru We have come to conclusion we will keep it as is, therefore on mobile, we will only have portrait. On tablet, we will have both portrait and landscape.

We might come back to this issue later. cc @AndrewGable

[mountiny]

Gonna close it for now, feel free to reopen anytime.