Skip to content

Workspace settings - App's orientation does not change to Landscape #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavimuru opened this issue Dec 11, 2021 · 16 comments
Closed

Workspace settings - App's orientation does not change to Landscape #6711

kavimuru opened this issue Dec 11, 2021 · 16 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Dec 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #6648

Action Performed:

  1. Launch the app
  2. Go to settings
  3. Tap on a workspace
  4. Change the orientation to landscape

Expected Result:

App's orientation changes to landscape

Actual Result:

App's orientation remains in Portrait

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.20-0
Reproducible in staging?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Image.from.iOS.MP4

Issue was found when executing #6648

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added the Daily KSv2 label Dec 11, 2021
@mountiny
Copy link
Contributor

Removing deploy blocker as it does not seem very urgent. However, I have teated on staging and the I cant switch to landscape at any screen.

@luacmartins
Copy link
Contributor

This is intentional after this PR #6608. I think we can close this issue, unless not being able to change to landscape mode is blocking some functionality.

@mountiny
Copy link
Contributor

@luacmartins thank you for a heads up! Is there an official way to update QA tests so they test for not being able to turn to landscape instead? 😅

@mountiny mountiny added Weekly KSv2 and removed External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Dec 11, 2021
@mountiny
Copy link
Contributor

Based on the Slack thread linked in the issue by Carlos, also here, this is intentional and on phones, we should not be able to rotate to landscape anymore.

However, the rotation should be possible on tablets.

@kavimuru could you please update the testing instructions to make sure we correctly QA for this new expected behaviour? Thank you very much 🙇

@ogumen
Copy link

ogumen commented Dec 13, 2021

@mountiny from the accessibility perspective restricting the content view and operation to a single display orientation fails WCAG 2.1 SC 1.3.4

@mountiny
Copy link
Contributor

@ogumen ah, thank you for raising this issue. It has been a decision made by more people so i will need to discuss with them.

@kavimuru
Copy link
Author

@mountiny, I have edited the steps. Also it works fine in iPad though.

CTUV5023.MP4

.

@mountiny
Copy link
Contributor

Thank you @kavimuru! I will bring up the accessibility issues in Slack to see what is our approach here and whether to revert this decision now knowing it breaks accessibility rules.

@mountiny
Copy link
Contributor

@ogumen Brought this issue up in Slack.

@mountiny
Copy link
Contributor

Discussion still going on.

@mountiny
Copy link
Contributor

The teams are still discussing this coming to Christmas break.

@mountiny
Copy link
Contributor

mountiny commented Jan 4, 2022

@kavimuru We have come to conclusion we will keep it as is, therefore on mobile, we will only have portrait. On tablet, we will have both portrait and landscape.

We might come back to this issue later. cc @AndrewGable

@mountiny
Copy link
Contributor

mountiny commented Jan 4, 2022

Gonna close it for now, feel free to reopen anytime.

@mountiny mountiny closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants