Skip to content

[Due for payment 2025-06-11] [Report Creation UI] Android - Infinite loading of unreported expenses with long list and fast scrolling #62954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 8 tasks
nlemma opened this issue May 28, 2025 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@nlemma
Copy link

nlemma commented May 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.53-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - Unreported expenses don't show up on prod (Possibly new feature)
If this was caught during regression testing, add the test name, ID and link from TestRail: #62651
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

  1. Navigate to https://staging.new.expensify.com

  2. Create a lot of unreported expenses +50

  3. Enter expense report that has option to add expenses

  4. Choose option to Add unreported expenses.

  5. Scroll to the bottom

Expected Result:

All the unreported expenses load

Actual Result:

Infinite loading is show

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6844329_1748424467588.XRecorder_20250528_08.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify
@nlemma nlemma added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 28, 2025
Copy link

melvin-bot bot commented May 28, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 28, 2025

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 28, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 28, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nlemma
Copy link
Author

nlemma commented May 28, 2025

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@blame-gpt
Copy link

blame-gpt commented May 28, 2025

Possible culprit PRs for this issue

@sumo-slonik
Copy link
Contributor

Hi, I'm Kuba from SWM, and I'm already taking a look at it.

@sumo-slonik
Copy link
Contributor

@nlemma Are you still able to reproduce this? It seems that after adding well over 50 unreported expenses, I’m not seeing the same behavior on my emulator. Maybe it was just a temporary issue with receiving a response from the backend.

@AndrewGable
Copy link
Contributor

Hey @sumo-slonik and @SzymczakJ @mountiny @luacmartins @DylanDylann - Should we try reverting #62651 ?

@sumo-slonik
Copy link
Contributor

sumo-slonik commented May 28, 2025

Hey @AndrewGable , why should we revert this? I’m not convinced the issue is actually reproducible. Can we first make sure that we’re actually able to reproduce this bug?

@AndrewGable
Copy link
Contributor

We should revert it because it's our goal to get these closed ASAP and the deploy out ASAP. I will look and see if I can reproduce.

I did not see the site having any issues during the time in which this test was being run: https://status.expensify.com/

@luacmartins
Copy link
Contributor

The logs don't show any slow commands in the API. Given that most of the requests have offset: 0 I think the issue might be related to the offset not updating correctly or triggering the request multiple times. Let's try to reproduce it first.

@AndrewGable
Copy link
Contributor

AndrewGable commented May 28, 2025

Reproduced on [email protected] by following the steps above

Google.Chrome.2025-05-28.at.11.27.09.mp4
Google.Chrome.2025-05-28.at.11.27.58.mp4

@luacmartins
Copy link
Contributor

luacmartins commented May 28, 2025

Requests seem to be correct and returned fast. So the issue is the FE handling the results and loading state

Image

@AndrewGable
Copy link
Contributor

I do believe you have to scroll quite fast for the loading to become "stuck"

@AndrewGable
Copy link
Contributor

I have the revert PR prepared but we can also choose to demote. I could see it going either way!

@trjExpensify
Copy link
Contributor

You can demote it as it's behind the trad reports beta. But regardless, I'd not block on it either given the size of the list of unreported expenses required and speed of scrolling to get stuck.

@AndrewGable
Copy link
Contributor

Sounds good, I will demote and assign!

@AndrewGable AndrewGable added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 28, 2025
@trjExpensify trjExpensify changed the title Android - Expense - Infinite loading of unreported expenses [Report Creation UI] Android - Infinite loading of unreported expenses with long list and fast scrolling May 28, 2025
@trjExpensify trjExpensify moved this to Second Cohort - HIGH in [#whatsnext] #migrate May 28, 2025
@trjExpensify trjExpensify moved this from Second Cohort - HIGH to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrate May 28, 2025
@sumo-slonik
Copy link
Contributor

It's possible that I was scrolling too slowly on the emulator, so I'll try it on a physical device. I'm getting to fixing it now

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 29, 2025
@luacmartins luacmartins self-assigned this May 29, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 4, 2025
@melvin-bot melvin-bot bot changed the title [Report Creation UI] Android - Infinite loading of unreported expenses with long list and fast scrolling [Due for payment 2025-06-11] [Report Creation UI] Android - Infinite loading of unreported expenses with long list and fast scrolling Jun 4, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 4, 2025
Copy link

melvin-bot bot commented Jun 4, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 4, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-06-11. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 4, 2025

@AndrewGable / @luacmartins @trjExpensify @sumo-slonik The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@trjExpensify
Copy link
Contributor

Adding @jayeshmangwani for payment when due.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Status: Second Cohort - MEDIUM or LOW
Development

No branches or pull requests

8 participants