-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-06-11] [Report Creation UI] Android - Infinite loading of unreported expenses with long list and fast scrolling #62954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @VictoriaExpensify ( |
Triggered auto assignment to @AndrewGable ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
Possible culprit PRs for this issue
|
Hi, I'm Kuba from SWM, and I'm already taking a look at it. |
@nlemma Are you still able to reproduce this? It seems that after adding well over 50 unreported expenses, I’m not seeing the same behavior on my emulator. Maybe it was just a temporary issue with receiving a response from the backend. |
Hey @sumo-slonik and @SzymczakJ @mountiny @luacmartins @DylanDylann - Should we try reverting #62651 ? |
Hey @AndrewGable , why should we revert this? I’m not convinced the issue is actually reproducible. Can we first make sure that we’re actually able to reproduce this bug? |
We should revert it because it's our goal to get these closed ASAP and the deploy out ASAP. I will look and see if I can reproduce. I did not see the site having any issues during the time in which this test was being run: https://status.expensify.com/ |
The logs don't show any slow commands in the API. Given that most of the requests have |
Reproduced on [email protected] by following the steps above Google.Chrome.2025-05-28.at.11.27.09.mp4Google.Chrome.2025-05-28.at.11.27.58.mp4 |
I do believe you have to scroll quite fast for the loading to become "stuck" |
I have the revert PR prepared but we can also choose to demote. I could see it going either way! |
You can demote it as it's behind the trad reports beta. But regardless, I'd not block on it either given the size of the list of unreported expenses required and speed of scrolling to get stuck. |
Sounds good, I will demote and assign! |
It's possible that I was scrolling too slowly on the emulator, so I'll try it on a physical device. I'm getting to fixing it now |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-06-11. 🎊 For reference, here are some details about the assignees on this issue:
|
@AndrewGable / @luacmartins @trjExpensify @sumo-slonik The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Adding @jayeshmangwani for payment when due. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.53-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - Unreported expenses don't show up on prod (Possibly new feature)
If this was caught during regression testing, add the test name, ID and link from TestRail: #62651
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other
Action Performed:
Navigate to https://staging.new.expensify.com
Create a lot of unreported expenses +50
Enter expense report that has option to add expenses
Choose option to Add unreported expenses.
Scroll to the bottom
Expected Result:
All the unreported expenses load
Actual Result:
Infinite loading is show
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6844329_1748424467588.XRecorder_20250528_08.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: