Skip to content

Return empty TryNewDot NVP as object #62520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Julesssss opened this issue May 21, 2025 · 1 comment
Open

Return empty TryNewDot NVP as object #62520

Julesssss opened this issue May 21, 2025 · 1 comment
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@Julesssss
Copy link
Contributor

Julesssss commented May 21, 2025

Problem

As discussed here, to unblock the ReactNative HybridApp signin page we need to modify the backend onyx response for authentication API calls.

Solution

Instead of returning an empty array we need to return an empty object from the following commands:

  • BeginSignIn
  • SignInUser

Then make sure to run these tests again

@Julesssss Julesssss self-assigned this May 21, 2025
@Julesssss Julesssss added Daily KSv2 Improvement Item broken or needs improvement. Engineering Reviewing Has a PR in review labels May 21, 2025
@Julesssss
Copy link
Contributor Author

Julesssss commented May 21, 2025

Draft PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

1 participant