-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Expense - Report field on confirmation page shows submitted report, but the expense is created in a new report #62415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @bfitzexpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @marcaaron ( |
💬 A slack conversation has been started in #expensify-open-source |
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
This PR seems related... #62003 – Fix "Pay" & "Approve" buttons inside the report & when expenses are held Though, looking at the changes and I'm not too sure. This could be an API issue as well. |
@cristipaval can you confirm what the behavior is here. It seems like we're making changes in this PR. But not clear whether it would be worse to revert that at this point or accept this minor inconsistency (feels like the latter). |
Oh hmm even after reverting that it still does the same behavior. So, not sure what we were even "fixing" with that PR @daledah can you chime in here? |
yes I agree this can be demoted 👍 |
This is related to Instant Submit, and I think @garrettmknight knows best what the expected behavior is. I think that the expected result in the issue description is correct. So when delay submission is enabled, it should work like this:
|
@daledah could you please comment on this issue so I can assign you to it? |
@cristipaval I'm here |
Job added to Upwork: https://www.upwork.com/jobs/~021925137384397419631 |
Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new. |
@DylanDylann is the C+ here and @daledah is the external contributor to fix the issue |
I'll work on the PR soon. |
Please ping me if you need any help |
@DylanDylann PR is ready. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.47-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
Expected Result:
In Step 12, the Report field on the confirmation page should show a new report.
Actual Result:
In Step 12, the Report field on the confirmation page shows the submitted report from Step 3.
In Step 13, after submitting the expense, the expense is created in a new report, instead of the selected report as stated in Step 12.
Workaround:
Unknown
Platforms:
Screenshots/Videos
bug.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @daledahThe text was updated successfully, but these errors were encountered: