Skip to content

[$250] Expense - Report field on confirmation page shows submitted report, but the expense is created in a new report #62415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 of 8 tasks
vincdargento opened this issue May 20, 2025 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@vincdargento
Copy link

vincdargento commented May 20, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.47-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Delayed submissions is set to Manually.
  • Add approvals is enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Click Submit on the expense preview.
  5. Click on the expense preview.
  6. Click report header.
  7. Click Title, rename and save it (to remember easily).
  8. Go back to the main workspace chat.
  9. Click + > Create expense > Manual.
  10. Enter amount > Next.
  11. On confirmation page, click Show more.
  12. Note that Report field shows the expense report from Step 3.
  13. Click Create expense.

Expected Result:

In Step 12, the Report field on the confirmation page should show a new report.

Actual Result:

In Step 12, the Report field on the confirmation page shows the submitted report from Step 3.
In Step 13, after submitting the expense, the expense is created in a new report, instead of the selected report as stated in Step 12.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925137384397419631
  • Upwork Job ID: 1925137384397419631
  • Last Price Increase: 2025-05-21
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @daledah
@vincdargento vincdargento added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 20, 2025
Copy link

melvin-bot bot commented May 20, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 20, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented May 20, 2025

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 20, 2025

💬 A slack conversation has been started in #expensify-open-source

@vincdargento
Copy link
Author

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@marcaaron
Copy link
Contributor

This PR seems related...

#62003 – Fix "Pay" & "Approve" buttons inside the report & when expenses are held

Though, looking at the changes and I'm not too sure. This could be an API issue as well.

@marcaaron
Copy link
Contributor

@cristipaval can you confirm what the behavior is here. It seems like we're making changes in this PR. But not clear whether it would be worse to revert that at this point or accept this minor inconsistency (feels like the latter).

@marcaaron
Copy link
Contributor

Oh hmm even after reverting that it still does the same behavior. So, not sure what we were even "fixing" with that PR @daledah can you chime in here?

@marcaaron marcaaron assigned cristipaval and unassigned marcaaron May 20, 2025
@marcaaron marcaaron added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 20, 2025
@cristipaval
Copy link
Contributor

yes I agree this can be demoted 👍

@cristipaval
Copy link
Contributor

This is related to Instant Submit, and I think @garrettmknight knows best what the expected behavior is. I think that the expected result in the issue description is correct.

So when delay submission is enabled, it should work like this:

  • When the user submits a new expense in the expense chat, it should be added to an existing open expense report linked to the chat, or to a new one if no linked report is OPEN
  • The user can add expenses to Processing reports, by opening the expense report page and clicking on + button in the composer

@cristipaval
Copy link
Contributor

@daledah could you please comment on this issue so I can assign you to it?

@daledah
Copy link
Contributor

daledah commented May 21, 2025

@cristipaval I'm here

@cristipaval cristipaval added the External Added to denote the issue can be worked on by a contributor label May 21, 2025
@melvin-bot melvin-bot bot changed the title Expense - Report field on confirmation page shows submitted report, but the expense is created in a new report [$250] Expense - Report field on confirmation page shows submitted report, but the expense is created in a new report May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021925137384397419631

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@cristipaval cristipaval removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 21, 2025
@cristipaval
Copy link
Contributor

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@DylanDylann is the C+ here and @daledah is the external contributor to fix the issue

@cristipaval cristipaval added Weekly KSv2 and removed Daily KSv2 labels May 21, 2025
@daledah
Copy link
Contributor

daledah commented May 21, 2025

I'll work on the PR soon.

@DylanDylann
Copy link
Contributor

Please ping me if you need any help

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 22, 2025
@daledah
Copy link
Contributor

daledah commented May 22, 2025

@DylanDylann PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants