Skip to content

[Due for payment 2025-05-30] [Desktop Navigation] Save the last visited path for the Accounts pages #62320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mountiny opened this issue May 19, 2025 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented May 19, 2025

Desktop navigation follow up

Similar to this issue #56806, which focused on the settings tab - after splitting the workspaces and Account settings to two tabs, we need to refactor the logic and keep the last visited path in the Workspace settings as well as Account settings navigator

Issue OwnerCurrent Issue Owner: @isabelastisser
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 19, 2025
Copy link

melvin-bot bot commented May 19, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny mountiny moved this to In Progress in [#whatsnext] #convert May 19, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 21, 2025
@mountiny mountiny changed the title Save the last visited path for the Accounts pages [Desktop Navigation] Save the last visited path for the Accounts pages May 21, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 23, 2025
@melvin-bot melvin-bot bot changed the title [Desktop Navigation] Save the last visited path for the Accounts pages [Due for payment 2025-05-30] [Desktop Navigation] Save the last visited path for the Accounts pages May 23, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 23, 2025
Copy link

melvin-bot bot commented May 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

  • @borys3kk does not require payment (Contractor)
  • @dukenv0307 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented May 23, 2025

@dukenv0307 @isabelastisser @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@dukenv0307
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: N/A

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

Testcase 1:

  1. On wide screen go to accounts tab
  2. Select a tab there, for example preferences
  3. Go to any other tab, for example inbox
  4. Refresh site
  5. Go to accounts tab
  6. You should have been redirected to preferences

Testcase 2:

  1. On wide screen go to accounts tab
  2. Select a tab there, for example about
  3. Go to any other tab
  4. Refresh site
  5. Resize window to narrow layout
  6. Go to accounts tab
  7. You should be on main settings screen

Do we agree 👍 or 👎

@mountiny
Copy link
Contributor Author

Payments handled as part of the project so no need to pay here

@isabelastisser could you please help us with adding the new test rail cases? thanks!

@isabelastisser
Copy link
Contributor

All set!

@github-project-automation github-project-automation bot moved this from In Progress to Done in [#whatsnext] #convert May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Development

No branches or pull requests

4 participants