Skip to content

Workspace - After editing, category is not shown in alphabetical order #62299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 16 tasks
lanitochka17 opened this issue May 19, 2025 · 4 comments
Closed
3 of 16 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9 1.46-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6137069
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Go to workspace settings
  3. Tap category
  4. Tap category - advertising
  5. Just add some text at the end of the word "advertising" as eg: advertisinggkssjjdj

Expected Result:

After editing, category must be shown in alphabetical order

Actual Result:

After editing, category is not shown in alphabetical order

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6835907_1747667762048.Screenrecorder-2025-05-19-20-42-46-302.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 19, 2025
Copy link

melvin-bot bot commented May 19, 2025

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

duplicate #62184

@dmkt9
Copy link
Contributor

dmkt9 commented May 19, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

After editing, category is not shown in alphabetical order

What is the root cause of that problem?

Since the useSearchResults function checks the previous filter input value, if there is no change, the sortData is not applied:

if (prevInputValueRef.current === inputValue) {
setResult(filtered);
return;
}

What changes do you think we should make in order to solve the problem?

Add a condition to check for differences in data. If there is a difference, the function inside the if statement should not be executed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 19, 2025

Thanks @lanitochka17 closing this as a dupe of #62184

@dmkt9 thanks for creating the proposal, feel free to post it in this GH for review #62184, if the other fix doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants