Skip to content

Focus is not set on the edited message when editing is selected #62174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
jponikarchuk opened this issue May 16, 2025 · 10 comments
Closed
3 of 8 tasks

Focus is not set on the edited message when editing is selected #62174

jponikarchuk opened this issue May 16, 2025 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6117064
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: MacOS 15.4.1 / safari, Chrome, Desktop
App Component: Other

Action Performed:

  1. Open Desktop App or go to staging.new.expensify.com
  2. Login with any account
  3. Go to any chat
  4. Edit any message from context menu or the last message with Up arrow key

Expected Result:

The message is in editing mode. Focus is set to the message.

Actual Result:

The message is in editing mode. Focus is not set on the edited message when editing is selected

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@jponikarchuk jponikarchuk added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 16, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NikkiWines
Copy link
Contributor

NikkiWines commented May 16, 2025

Hmm unable to reproduce this on dev, trying staging now nvm able to reproduce on staging and dev

@MonilBhavsar
Copy link
Contributor

@NikkiWines we're reverting an offending PR that might fix this issue
https://expensify.slack.com/archives/C01GTK53T8Q/p1747366352030189

@NikkiWines
Copy link
Contributor

Nice! Thanks @MonilBhavsar - tested locally and confirmed your revert fixes the issue on dev

@MonilBhavsar
Copy link
Contributor

Awesome! 🚀

@IuliiaHerets
Copy link

Issue is not reproduced anymore

62174-Desktop.mp4

@techievivek
Copy link
Contributor

This is fixed so we can close it out.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels May 19, 2025
@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants