[$125] Investigate workflow job failing on main: test / test (job 1)

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: test / test (job 1)
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @francoisl
• 🤝 Merged by: @mountiny
• 🐛 Error Message:
  failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 1).
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021923284688403931634
• Upwork Job ID: 1923284688403931634
• Last Price Increase: 2025-05-16
• Automatic offers:
• nkdengineer | Contributor | 107338624

Issue Owner

Current Issue Owner: @

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021923284688403931634

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[mountiny]

This rest seems flaky, looking for proposals to fix it

[melvin-bot]

Upwork job price has been updated to $125

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-16 08:49:31 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

test flaky

What is the root cause of that problem?

We use createRandomReport function in this test

App/tests/unit/ReportUtilsTest.ts

Lines 2579 to 2586 in 9e0ae4f

	it('should exclude hidden participants', () => {
	const report: Report = {
	...createRandomReport(1),
	participants: {
	1: {notificationPreference: 'hidden'},
	2: {notificationPreference: 'always'},
	},
	};

this will result in the value of shouldExcludeHiddenParticipants being flaky

App/src/libs/ReportUtils.ts

Lines 2794 to 2796 in 9e0ae4f

	const isReportGroupChat = isGroupChat(report);
	const shouldExcludeHiddenParticipants = !isReportGroupChat && !isMoneyRequestReport(report) && !isMoneyRequest(report);
	const chatParticipants = getParticipantsAccountIDsForDisplay(report, isRoomMembersList || shouldExcludeHiddenParticipants, false, false, reportMetadata);

What changes do you think we should make in order to solve the problem?

We should add type and chatType for this report

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[ishpaul777]

test was added in #61818, i remember test passing can you help me understand what changed since then @nkdengineer

[nkdengineer]

@ishpaul777, as you can see in createRandomReport, we randomly chatType in here

App/tests/utils/collections/reports.ts

Lines 5 to 17 in 587d411

	export default function createRandomReport(index: number): Report {
	return {
	reportID: index.toString(),
	chatType: rand(Object.values(CONST.REPORT.CHAT_TYPE)),
	currency: randCurrencyCode(),
	ownerAccountID: index,
	isPinned: randBoolean(),
	isOwnPolicyExpenseChat: randBoolean(),
	isWaitingOnBankAccount: randBoolean(),
	policyID: index.toString(),
	reportName: randWord(),
	};
	}

And in this condition, when chatType is GROUP type => shouldExcludeHiddenParticipants will be false => We fail this test

App/src/libs/ReportUtils.ts

Lines 2794 to 2796 in 9e0ae4f

	const isReportGroupChat = isGroupChat(report);
	const shouldExcludeHiddenParticipants = !isReportGroupChat && !isMoneyRequestReport(report) && !isMoneyRequest(report);
	const chatParticipants = getParticipantsAccountIDsForDisplay(report, isRoomMembersList || shouldExcludeHiddenParticipants, false, false, reportMetadata);

[ishpaul777]

@nkdengineer thx, it makes sense

proposal seems good 👍

🎀 👀 🎀

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖