Report field opens Not here page when sharing expense to accountant on confirmation page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in to Expensifail account.
• Account has self DM.

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Submit an expense to the workspace chat.
5. Go to self DM.
6. Track a manual expense.
7. Click Share it with my account.
8. Select any accountant.
9. On confirmation page, click More.
10. Click Report.

Expected Result:

Report list will open.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens.

What is the root cause of that problem?

It comes from #61839.

When we share with the accountant, the transaction.reportID string is 0 so it doesn't fall back to the reportID from participant.

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Line 25 in eecf578

const reportID = transaction?.reportID || transaction?.participants?.at(0)?.reportID;

What changes do you think we should make in order to solve the problem?

We should update the reportID to get from the participant if the transaction.reportID is 0

const reportID = transaction?.reportID === '0' ? transaction?.participants?.at(0)?.reportID : transaction?.reportID;

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Line 25 in eecf578

const reportID = transaction?.reportID || transaction?.participants?.at(0)?.reportID;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jnowakow]

@nkdengineer's solution seems correct. Should I fix it since it's regression from my PR or should it be him?

[techievivek]

Ideally, the author of a PR is responsible for fixing any regressions it causes, unless they're unavailable for some reason.

[jnowakow]

Okey, so here's the PR