Skip to content

Expense - Unable to move expense to the report of a track expense. #62154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 8 tasks
mitarachim opened this issue May 16, 2025 · 14 comments
Open
3 of 8 tasks

Expense - Unable to move expense to the report of a track expense. #62154

mitarachim opened this issue May 16, 2025 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a Self DM and at least one workspace available.
Prerequisite 2: Delayed submissions and approvals disabled.

  1. Open the Expensify app.
  2. Tap on FAB and select "Create Expense"
  3. Complete the creation flow and submit the expense to Self DM.
  4. Tap on "Share with my accountant" below expense preview.
  5. Add an accountant.
  6. Select a workspace to submit the expense to.
  7. Complete creation flow and submit it to the chosen workspace.
  8. Once redirected to chat, submit a new manual expense to it.
  9. Open the last expense.
  10. Tap on "More" and select "Move Expense"
  11. Select the report of the first expense.
  12. Note that after the last action, you land on the report of the first expense.
  13. Tap on the back button on the top left corner.
  14. Note that you land on an empty report.
  15. Tap on the back button again.
  16. Note that you land on chat and both expenses remain on separated reports.

Expected Result:

User should be able to move an expense to a different report without any issue.

Actual Result:

When moving an expense to the report of a different expense, the user lands on the report of the second one, but no changes can be seen on amount or information. After that, when tapping on back button, the user lands on the report of the moved expense, but all the information fields are empty, and when returning to chat, both expenses remain separated on different reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6832595_1747350753617.Moved.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 16, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 16, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@robertjchen robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels May 16, 2025
@robertjchen
Copy link
Contributor

@jnowakow could this be related to the changes from #61839 🙏

@robertjchen robertjchen added the DeployBlockerCash This issue or pull request should block deployment label May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 16, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels May 16, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@pecanoro pecanoro removed their assignment May 16, 2025
@jnowakow
Copy link
Contributor

Actually there's API error so I think we have to modify canEditFieldOfMoneyRequest that is used to determine if expense can be moved.

Image

Actually this happens also when change is initialised from report field so I don't think it was caused by #61839

Screen.Recording.2025-05-16.at.11.32.33.mov

@robertjchen
Copy link
Contributor

Got it, thanks for the additional info!

@robertjchen
Copy link
Contributor

Found the logs for that requestid 9409dea6dcdcbbb7-WAW

User is trying to add expense to Non-Reimbursable report: 2547887048538028 on policy 00A30C4E0D29BFAD with Instant Submit Enabled and No Approvers.

I guess this is expected since that check has been there for 9 months now, we're probably just not showing an error on the frontend? @mitarachim Could you please confirm if the the expense was being moved onto an non-reimbursable report with instant submit enabled and no approvers in your test case? 🙏

@mitarachim
Copy link
Author

Hello @robertjchen sorry for very late respond.
i can confirm the expense is not move onto non-reimbursable report with instant submit enabled and no approvers.

2025-05-18.9.34.23.AM.mp4

@melvin-bot melvin-bot bot added the Overdue label May 19, 2025
@robertjchen
Copy link
Contributor

Got it, thanks for the confirmation- since this appears to be more of a backend issue not related to the recent frontend PR, I'll remove the DeployBlockerCash while we investigate further.

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
@robertjchen robertjchen added Overdue Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 19, 2025
@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
@robertjchen robertjchen added Hourly KSv2 Overdue Daily KSv2 and removed Daily KSv2 Hourly KSv2 labels May 19, 2025
@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
@luacmartins
Copy link
Contributor

I tried reproducing this but I encountered a different error. I see 403 New expense cannot be added to this report, which is thrown here. It seems like we have a check that prevents us from moving a transaction to a report with only non-reimbursable transactions if the workspace has instant submit enabled and no approvals.

@youssef-lr do you have more context on why this check was added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants