Skip to content

[Due for payment 2025-05-28] [Due for payment 2025-05-27] Account - Account tab is accessible when navigating to public room as guest #62153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue May 16, 2025 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented May 16, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: User Settings

Action Performed:

  1. Copy link to a public room (https://staging.new.expensify.com/r/4689164261781701).
  2. Log out of ND if logged in.
  3. Navigate to the public room as guest.
  4. Click Account tab.

Expected Result:

Login modal will open.

Actual Result:

Account page opens. The subsections open login modal.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6832618_1747354229434.20250516_080824.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bfitzexpensify
@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 16, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 16, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@WojtekBoman
Copy link
Contributor

Hey, I'll take care of it as I'm the author of the offending PR. I will wrap function navigating to Account with interceptAnonymousUser

@techievivek
Copy link
Contributor

Thanks

@techievivek techievivek removed the DeployBlocker Indicates it should block deploying the API label May 16, 2025
@IuliiaHerets
Copy link

@techievivek Issue was fixed already

20250516_202424.mp4

@techievivek
Copy link
Contributor

Gonna close this now.

@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label May 20, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 20, 2025
@melvin-bot melvin-bot bot changed the title Account - Account tab is accessible when navigating to public room as guest [Due for payment 2025-05-27] Account - Account tab is accessible when navigating to public room as guest May 20, 2025
Copy link

melvin-bot bot commented May 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 20, 2025
Copy link

melvin-bot bot commented May 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 20, 2025

@techievivek @bfitzexpensify @WojtekBoman The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 21, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-27] Account - Account tab is accessible when navigating to public room as guest [Due for payment 2025-05-28] [Due for payment 2025-05-27] Account - Account tab is accessible when navigating to public room as guest May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 21, 2025

@techievivek @bfitzexpensify @WojtekBoman The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants